Skip to content

gh-135557: Use atomic writes on heapq operations #135601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

xuantengh
Copy link
Contributor

@xuantengh xuantengh commented Jun 17, 2025

Use atomic writes on heapq operation.

@xuantengh xuantengh requested a review from rhettinger as a code owner June 17, 2025 05:22
@xuantengh xuantengh changed the title gh-135557: Fix lock-free list access on heapq gh-135557: Use atomic writes on heapq operations Jun 17, 2025
@xuantengh
Copy link
Contributor Author

I think this could be "skip news"?

@rhettinger rhettinger removed their request for review June 17, 2025 12:51
@ZeroIntensity
Copy link
Member

I think this could be "skip news"?

This is user-facing, so this does need a news. Something like "Fix race with lists and heapq on the free threaded build" would be fine. It would also be good to get a test. (Sorry for pushing back on both your PRs!)

@ZeroIntensity ZeroIntensity added the needs backport to 3.14 bugs and security fixes label Jun 17, 2025
@xuantengh xuantengh force-pushed the heap-list-lock-free-read branch from f7fbb68 to 08770ec Compare June 17, 2025 16:16
@python-cla-bot
Copy link

python-cla-bot bot commented Jun 18, 2025

All commit authors signed the Contributor License Agreement.

CLA signed

@xuantengh xuantengh force-pushed the heap-list-lock-free-read branch from 0184b21 to 463963d Compare June 18, 2025 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants