gh-89488: Add warning about Py_BuildValue("p") needing exact int
#135610
+6
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bedevere-app
bot
added
awaiting core review
docs
Comment on lines
+689
to
+693
| Be aware that this format requires an ``int`` argument. | ||
| Unlike most other contexts in C, variadic arguments are not coerced to | ||
| a suitable type automatically. | ||
| You can convert another type (for example, a pointer or a float) to a | ||
| suitable ``int`` value using ``(x) ? 1 : 0`` or ``!!x``. |
There was a problem hiding this comment.
Would it make sense to put this inside a .. note:: directive, like the .. note:: This format does not accept bytes-like objects above?
Suggested change
| Be aware that this format requires an ``int`` argument. | |
| Unlike most other contexts in C, variadic arguments are not coerced to | |
| a suitable type automatically. | |
| You can convert another type (for example, a pointer or a float) to a | |
| suitable ``int`` value using ``(x) ? 1 : 0`` or ``!!x``. | |
| .. note:: | |
| This format requires an ``int`` argument. | |
| Unlike most other contexts in C, variadic arguments are not coerced to | |
| a suitable type automatically. | |
| You can convert another type (for example, a pointer or a float) to a | |
| suitable ``int`` value using ``(x) ? 1 : 0`` or ``!!x``. |
There was a problem hiding this comment.
I wouldn't mind, but, I don't think this needs to be called out so prominently. An extra paragraph is already pretty noticeable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📚 Documentation preview 📚: https://cpython-previews--135610.org.readthedocs.build/