gh-135641: Fix flaky test_capi.test_lock_two_threads test case
#135642
+4
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The mutex may have the _Py_HAS_PARKED bit set in rare cases.
colesbury
added
skip news
needs backport to 3.13
mpage
reviewed
Jun 17, 2025
Comment on lines
+60
to
+62
| // gh-135641: in rare cases the lock may still have `_Py_HAS_PARKED` set | ||
| // (m->_bits == 3) due to bucket collisions in the parking lot hash table | ||
| // between this mutex and the `test_data.done` event. |
There was a problem hiding this comment.
Are there any consequences of this being set incorrectly? I think another solution, though much more invasive, might be to move num_waiters from Bucket onto wait_entry.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The mutex may have the
_Py_HAS_PARKEDbit set in rare cases.test_lock_two_threadsflaky intest_capi#135641