Skip to content

gh-102555: Fix comment parsing in HTMLParser #135664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

gh-102555: Fix comment parsing in HTMLParser #135664

wants to merge 4 commits into from
+50 −3

Conversation

serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented Jun 18, 2025 •
edited by bedevere-app bot
Loading

  • "--!>" now ends the comment.
  • "-- >" no longer ends the comment.
  • Support abnormally ended empty comments "<-->" and "<--->".

@serhiy-storchaka
pythongh-135661: Fix comment parsing in HTMLParser
2706182 
* "--!>" now ends the comment.
* "-- >" no longer ends the comment.
* Support abnormally ended empty comments "<-->" and "<--->".
@serhiy-storchaka serhiy-storchaka added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Jun 18, 2025
@bedevere-app bedevere-app bot mentioned this pull request Jun 18, 2025
Open
@serhiy-storchaka serhiy-storchaka mentioned this pull request Jun 25, 2025
Closed
@serhiy-storchaka serhiy-storchaka changed the title gh-135661: Fix comment parsing in HTMLParser gh-102555: Fix comment parsing in HTMLParser Jun 25, 2025
@bedevere-app bedevere-app bot mentioned this pull request Jun 25, 2025
Open
Privat33r-dev
Privat33r-dev reviewed Jun 25, 2025
View reviewed changes
Copy link
Contributor

@Privat33r-dev Privat33r-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solid implementation overall :)

Lib/html/parser.py
@@ -309,6 +310,21 @@ def parse_html_declaration(self, i):
else:
return self.parse_bogus_comment(i)

# Internal -- parse comment, return length or -1 if not terminated
# see https://html.spec.whatwg.org/multipage/parsing.html#comment-start-state
def parse_comment(self, i, report=True):
Copy link
Contributor

@Privat33r-dev Privat33r-dev Jun 25, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if the change should be made in the _markupbase.

cpython/Lib/_markupbase.py

Lines 165 to 175 in c2f2fd4

def parse_comment(self, i, report=1):
rawdata = self.rawdata
if rawdata[i:i+4] != '<!--':
raise AssertionError('unexpected call to parse_comment()')
match = _commentclose.search(rawdata, i+4)
if not match:
return -1
if report:
j = match.start(0)
self.handle_comment(rawdata[i+4: j])
return match.end(0)

If the method is overloaded here, then there are no other use cases, and the original method becomes dead code.
https://github.com/search?q=repo%3Apython%2Fcpython%20parse_comment&type=code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Privat33r-dev Privat33r-dev Privat33r-dev left review comments

@ezio-melotti ezio-melotti Awaiting requested review from ezio-melotti ezio-melotti is a code owner

Assignees
No one assigned
Labels
awaiting core review needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@serhiy-storchaka @Privat33r-dev