Skip to content

add async generators section to asyncio internal docs #135674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jun 23, 2025
Merged

add async generators section to asyncio internal docs #135674

merged 6 commits into from
Jun 23, 2025
+122 −4

Conversation

kumaraditya303
Copy link
Contributor

@kumaraditya303 kumaraditya303 commented Jun 18, 2025 •
edited
Loading

This documents the implementation details of async generators in asyncio.

@bedevere-app bedevere-app bot added awaiting core review docs Documentation in the Doc dir labels Jun 18, 2025
@github-project-automation github-project-automation bot moved this to Todo in Docs PRs Jun 18, 2025
StanFromIreland
StanFromIreland reviewed Jun 18, 2025
View reviewed changes
Copy link
Member

@StanFromIreland StanFromIreland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well written IMO (apart from a few small grammar things).

I love the flowchart, I had no idea github supports them!

@kumaraditya303 @StanFromIreland
Apply suggestions from code review
ba1a1a0 
Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
gvanrossum
gvanrossum reviewed Jun 22, 2025
View reviewed changes
Copy link
Member

@gvanrossum gvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the late review (I have been procrastinating on all sorts of stuff :-( ). Looks good, only a few nits.

kumaraditya303 and others added 2 commits June 22, 2025 09:14
gvanrossum
gvanrossum approved these changes Jun 23, 2025
View reviewed changes
Copy link
Member

@gvanrossum gvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After fixing that feel free to merge it!

@kumaraditya303 kumaraditya303 enabled auto-merge (squash) June 23, 2025 06:22
@kumaraditya303 kumaraditya303 merged commit 0d9d489 into python:main Jun 23, 2025
25 checks passed
@github-project-automation github-project-automation bot moved this from Todo to Done in Docs PRs Jun 23, 2025
@kumaraditya303 kumaraditya303 deleted the asyncio-asyncgen-docs branch June 23, 2025 06:23
@kumaraditya303 kumaraditya303 restored the asyncio-asyncgen-docs branch June 23, 2025 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StanFromIreland StanFromIreland StanFromIreland left review comments

@gvanrossum gvanrossum gvanrossum approved these changes

@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner

@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner

@willingc willingc Awaiting requested review from willingc willingc is a code owner

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip issue skip news topic-asyncio
Projects
Docs PRs
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kumaraditya303 @gvanrossum @StanFromIreland