Skip to content

gh-135721: skip test_trashcan_python_class on wasm buildbots with stack overflow #135766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 20, 2025
Merged

gh-135721: skip test_trashcan_python_class on wasm buildbots with stack overflow #135766

merged 2 commits into from
Jun 20, 2025
+2 −0

Conversation

Lancetnik
Copy link
Contributor

@Lancetnik Lancetnik commented Jun 20, 2025 •
edited
Loading

@Lancetnik Lancetnik requested a review from markshannon as a code owner June 20, 2025 15:25
@python-cla-bot
Copy link

python-cla-bot bot commented Jun 20, 2025 •
edited
Loading

All commit authors signed the Contributor License Agreement.

CLA signed

@bedevere-app bedevere-app bot added awaiting review tests Tests in the Lib/test dir labels Jun 20, 2025
@bedevere-app
Copy link

bedevere-app bot commented Jun 20, 2025

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@bedevere-app bedevere-app bot mentioned this pull request Jun 20, 2025
Closed
@sobolevn
Copy link
Member

!buildbot wasi

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @sobolevn for commit 2ffd60e 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F135766%2Fmerge

The command will test the builders whose names match following regular expression: wasi

The builders matched are:

  • wasm32-wasi Non-Debug PR
  • wasm32-wasi PR
  • wasm32 WASI 8Core PR

sobolevn
sobolevn approved these changes Jun 20, 2025
View reviewed changes
Copy link
Member

@sobolevn sobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's see that buildbots are fine :)
Otherwise, LGTM!

@Lancetnik Lancetnik changed the title gh-135721: skip test_trashcan_python_class1 on wasm buildbots with stack overflow gh-135721: skip test_trashcan_python_class on wasm buildbots with stack overflow Jun 20, 2025
@sobolevn
Copy link
Member

!buildbot wasi

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @sobolevn for commit e3f67ee 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F135766%2Fmerge

The command will test the builders whose names match following regular expression: wasi

The builders matched are:

  • wasm32-wasi Non-Debug PR
  • wasm32-wasi PR
  • wasm32 WASI 8Core PR

sobolevn
sobolevn approved these changes Jun 20, 2025
View reviewed changes
Copy link
Member

@sobolevn sobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI on 3.14 is green. WASI buildbots do not fail. So, I would not add a backport now. It can be done in the future.

@sobolevn sobolevn merged commit 3fb6cfe into python:main Jun 20, 2025
42 checks passed
@brettcannon brettcannon added the needs backport to 3.14 bugs and security fixes label Jun 25, 2025
@miss-islington-app
Copy link

Thanks @Lancetnik for the PR, and @sobolevn for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 25, 2025
@Lancetnik @miss-islington
pythongh-135721: skip test_trashcan_python_class on wasm buildbots …
14ceb1d 
…with stack overflow (pythonGH-135766)

(cherry picked from commit 3fb6cfe)

Co-authored-by: Pastukhov Nikita <diementros@yandex.ru>
@bedevere-app
Copy link

bedevere-app bot commented Jun 25, 2025

GH-135955 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Jun 25, 2025
@brettcannon
Copy link
Member

CI on 3.14 is green. WASI buildbots do not fail. So, I would not add a backport now. It can be done in the future.

The future is now as I'm now getting this failure in 3.14 for #135950 .

brettcannon pushed a commit that referenced this pull request Jun 25, 2025
@miss-islington @Lancetnik
[3.14] gh-135721: skip test_trashcan_python_class on wasm buildbots…
c8e914c 
… with stack overflow (GH-135766) (GH-135955)

gh-135721: skip `test_trashcan_python_class` on wasm buildbots with stack overflow (GH-135766)
(cherry picked from commit 3fb6cfe)

Co-authored-by: Pastukhov Nikita <diementros@yandex.ru>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sobolevn sobolevn sobolevn approved these changes

@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

Assignees
No one assigned
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Lancetnik @sobolevn @bedevere-bot @brettcannon