Skip to content

[3.13] patchcheck: use URL paths to identify upstream remote (GH-135806) #135809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 23, 2025

Conversation

miss-islington
Copy link
Contributor

  • find defined "(fetch)" remotes with "python/cpython" in their URL
  • if there is exactly one, use that remote name
  • if there is one named "upstream", "origin", or "python",
    use that remote (in that precedence order)
  • otherwise report an error listing the defined remotes
    (cherry picked from commit ac9d37c)

Co-authored-by: Kattni kattni@kattni.com

* find defined "(fetch)" remotes with "python/cpython" in their URL
* if there is exactly one, use that remote name
* if there is one named "upstream", "origin", or "python",
  use that remote (in that precedence order)
* otherwise report an error listing the defined remotes
(cherry picked from commit ac9d37c)

Co-authored-by: Kattni <kattni@kattni.com>
@ncoghlan
Copy link
Contributor

This is close enough to the bug fix/enhancement boundary that I've asked for RM confirmation before merging it.

@hugovk
Copy link
Member

hugovk commented Jun 23, 2025

Thomas has confirmed this is okay for 3.13 (as long as it goes into 3.14 as well, which it has).

Thanks!

@hugovk hugovk merged commit b79e64b into python:3.13 Jun 23, 2025
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip issue skip news type-bug An unexpected behavior, bug, or error
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants