-
-
Notifications
You must be signed in to change notification settings - Fork 32.2k
gh-135815: skip netrc
security checks if os.getuid
is missing
#135816
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-135815: skip netrc
security checks if os.getuid
is missing
#135816
Conversation
c472cc9
to
d2a13f6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Added a couple of suggestions, it is up to you.
(f"~/.netrc file owner ({fowner}, {user}) does not match" | ||
" current user")) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The message looks weird. Would not be better to rewrite in in the following way?
(f"~/.netrc file owner ({fowner}) does not match"
f" current user ({user})"))
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll change it in a follow-up PR so that only unstable branches are affected.
Thanks @picnixz for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14. |
…ng (pythonGH-135816) (cherry picked from commit b57b619) Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
GH-135825 is a backport of this pull request to the 3.14 branch. |
…ng (pythonGH-135816) (cherry picked from commit b57b619) Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
GH-135826 is a backport of this pull request to the 3.13 branch. |
|
netrc
security check may fail on WASI due to the lack ofos.getuid
#135815