-
-
Notifications
You must be signed in to change notification settings - Fork 32.2k
gh-95245: Document Py_TPFLAGS_PREHEADER #135861
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
gh-95245: Document Py_TPFLAGS_PREHEADER #135861
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should include documentation on the type object page too.
@ZeroIntensity Thanks for review! Fixed (I hope :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that if this is internal-only, it would be better to completely drop it from public headers rather than document it as such.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't need news entries for documentation changes, I'll put skip news
on this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I will remove news entry as we got consensus.
(Don't do this yet, by the way. Let's come to a consensus in the issue.) |
I see following usages of Py_TPFLAGS_PREHEADER:
I checked all linked PR from #95245 and can't find any explanation. I also checked https://github.com/python/cpython/blob/main/Objects/object_layout.md.
@encukou Please take a look.