gh-135853: add math.fmax and math.fmin
#135888
Open
+263
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
picnixz
changed the title
math.fmax and math.fminmath.fmax and math.fmin [PoC]
picnixz
commented
Jun 24, 2025
skirpichev
reviewed
Jun 24, 2025
picnixz
force-pushed
the
feat/math/fmin-fmax-135853
branch
from
0831229 to
afb0a91
Compare
picnixz
commented
Jun 24, 2025
picnixz
changed the title
math.fmax and math.fmin [PoC]math.fmax and math.fmin
picnixz
commented
Jun 24, 2025
vstinner
reviewed
Jun 24, 2025
Comment on lines
+648
to
+656
| with self.subTest("math.fmax(INF, x)", x=x): | ||
| self.assertEqual(math.fmax(INF, x), INF) | ||
| with self.subTest("math.fmax(x, INF)", x=x): | ||
| self.assertEqual(math.fmax(x, INF), INF) | ||
|
|
||
| with self.subTest("math.fmax(NINF, x)", x=x): | ||
| self.assertEqual(math.fmax(NINF, x), x) | ||
| with self.subTest("math.fmax(x, NINF)", x=x): | ||
| self.assertEqual(math.fmax(x, NINF), x) |
There was a problem hiding this comment.
The traceback contains the line causing the assertion failure, I don't think that it's worth it to repeat it it subTest():
Suggested change
| with self.subTest("math.fmax(INF, x)", x=x): | |
| self.assertEqual(math.fmax(INF, x), INF) | |
| with self.subTest("math.fmax(x, INF)", x=x): | |
| self.assertEqual(math.fmax(x, INF), INF) | |
| with self.subTest("math.fmax(NINF, x)", x=x): | |
| self.assertEqual(math.fmax(NINF, x), x) | |
| with self.subTest("math.fmax(x, NINF)", x=x): | |
| self.assertEqual(math.fmax(x, NINF), x) | |
| with self.subTest(x=x): | |
| self.assertEqual(math.fmax(INF, x), INF) | |
| self.assertEqual(math.fmax(x, INF), INF) | |
| self.assertEqual(math.fmax(NINF, x), x) | |
| self.assertEqual(math.fmax(x, NINF), x) |
| with self.subTest("math.fmax(x, NINF)", x=x): | ||
| self.assertEqual(math.fmax(x, NINF), x) | ||
|
|
||
| @requires_IEEE_754 |
There was a problem hiding this comment.
Python requires IEEE 754 and NaN support to build: https://docs.python.org/dev/using/configure.html#build-requirements We should maybe start getting rid of this decorator?
There was a problem hiding this comment.
Other Python implementations may use this test suite as well.
Comment on lines
+694
to
+702
| with self.subTest("math.fmin(INF, x)", x=x): | ||
| self.assertEqual(math.fmin(INF, x), x) | ||
| with self.subTest("math.fmin(x, INF)", x=x): | ||
| self.assertEqual(math.fmin(x, INF), x) | ||
|
|
||
| with self.subTest("math.fmin(NINF, x)", x=x): | ||
| self.assertEqual(math.fmin(NINF, x), NINF) | ||
| with self.subTest("math.fmin(x, NINF)", x=x): | ||
| self.assertEqual(math.fmin(x, NINF), NINF) |
There was a problem hiding this comment.
Suggested change
| with self.subTest("math.fmin(INF, x)", x=x): | |
| self.assertEqual(math.fmin(INF, x), x) | |
| with self.subTest("math.fmin(x, INF)", x=x): | |
| self.assertEqual(math.fmin(x, INF), x) | |
| with self.subTest("math.fmin(NINF, x)", x=x): | |
| self.assertEqual(math.fmin(NINF, x), NINF) | |
| with self.subTest("math.fmin(x, NINF)", x=x): | |
| self.assertEqual(math.fmin(x, NINF), NINF) | |
| with self.subTest(x=x): | |
| self.assertEqual(math.fmin(INF, x), x) | |
| self.assertEqual(math.fmin(x, INF), x) | |
| self.assertEqual(math.fmin(NINF, x), NINF) | |
| self.assertEqual(math.fmin(x, NINF), NINF) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added
math.fminandmath.fmaxas I think it'd be nice to have the NaN handling as per C99. I didn't make those functions generic or accept any iterable argument.WDYT of this proposal @skirpichev @rhettinger?
math#135853📚 Documentation preview 📚: https://cpython-previews--135888.org.readthedocs.build/