Skip to content

feat: add patch file download with installation guidance #402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

mjstelly
Copy link

Summary

  • Implements comprehensive patch download feature for React Native upgrades
  • Provides single-file patches that can be applied with git apply
  • Includes interactive installation guidance with copy-friendly commands
  • Enhances Binaries button with clear explanations to eliminate user confusion

Key Features

  • One-click patch download with automatic app name/package customization
  • Installation modal with step-by-step instructions and copyable commands
  • Enhanced Binaries button with info tooltips explaining binary vs patch files
  • Smart integration that mentions binary files in patch instructions when present
  • Complete test coverage for all new components and functionality

Problem Solved

Addresses GitHub issue #398 by making React Native upgrades "less error prone" through:

  • Automated patch file generation from existing diff data
  • Clear user guidance on installation process
  • Elimination of confusion between patch files and binary downloads

Test Plan

  • Unit tests for PatchDownloadButton component
  • Unit tests for PatchInstructionsModal component
  • Integration tests for useFetchDiff hook with raw diff exposure
  • All existing tests continue to pass
  • Linting and formatting checks pass

Related Issues

Fixes #398

Michael Stelly added 2 commits June 13, 2025 12:27
  Implements comprehensive patch download feature to simplify React Native upgrades by providing single-file patches that can be applied with git. Includes clear differentiation from binary downloads to eliminate
  user confusion.

  Key features:
  - One-click patch file download with app name/package customization
  - Interactive installation modal with copy-friendly command snippets
  - Enhanced Binaries button with explanatory tooltips
  - Smart integration that mentions binary files when present
  - Complete test coverage for all new components

  This addresses GitHub issue react-native-community#398 by making React Native upgrades less error-prone through automated patch application while maintaining clarity about manual binary file handling.
@pvinis
Copy link
Member

pvinis commented Jun 14, 2025

feel free to open up an issue before a PR, to let us know what the problem you want to solve is. Others might have the same issue, or a solution.

@pvinis pvinis closed this Jun 14, 2025
@mjstelly
Copy link
Author

The feature request had already been opened and it was referenced in the PR. @pvinis. What more do you need?

@pvinis
Copy link
Member

pvinis commented Jun 14, 2025

We will not be adding patch files for upgrades. I have updated the issue you reference.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Full patch file
2 participants