Do not include NUL-terminator in computed length #142708
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
rustbot has assigned @Mark-Simulacrum. Use |
rustbot
added
S-waiting-on-review
5 tasks
| // A raw pointer is used rather than a reference because the pointer is valid for one more byte | ||
| // than the length stored in this pointer; the additional byte is the NUL-terminator used by | ||
| // `Location::file_with_nul`. | ||
| filename: *const str, |
There was a problem hiding this comment.
Maybe it should be NonNull to keep at least some of the niche in Location? I think this change would make Option larger, right?
I'm not 100% sure but I think expanding a &'a [u8] is also sound - I don't think the memory model cares about the length of [u8], only the underlying object.
Mark-Simulacrum
added
S-waiting-on-author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains just the first commit of #142579 which changes it so that the string length stored in the
Locationis the length of the&strrather than the length of the&CStr. Since most users will want the&strlength, it seems better to optimize for that use-case.There should be no visible changes in the behavior or API.