Canonicalize input ty/ct infer/placeholder in the root universe #142732

compiler-errors · 2025-06-19T17:48:22Z

We shouldn't care what universe the inputs are, since we only ever do the leak check on the universes instantiated after entering the canonical binder.

compiler-errors · 2025-06-19T17:48:33Z

@bors2 try @rust-timer queue

[perf] Canonicalize input ty/ct infer/placeholder in the root universe meow

rust-bors · 2025-06-19T17:48:37Z

⌛ Trying commit 334396a with merge 46d20f6…

To cancel the try build, run the command @bors2 try cancel.

rust-bors · 2025-06-19T20:19:48Z

☀️ Try build successful (CI)
Build commit: 46d20f6 (46d20f64bffb874fc758158dac884838b14b4eb4, parent: 2fcf1776b9ccef89993dfe40e9f5c4908e2d2d48)

rust-timer · 2025-06-20T10:42:23Z

Finished benchmarking commit (46d20f6): comparison URL.

Overall result: ✅ improvements - no action needed

Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.3%	[-0.5%, -0.2%]	8
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results (primary -1.2%, secondary -4.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-1.2%	[-1.5%, -1.0%]	2
Improvements ✅ (secondary)	-4.1%	[-6.1%, -2.2%]	2
All ❌✅ (primary)	-1.2%	[-1.5%, -1.0%]	2

Cycles

Results (secondary 4.7%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	4.7%	[4.7%, 4.7%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 692.244s -> 694.134s (0.27%)
Artifact size: 371.99 MiB -> 372.00 MiB (0.00%)

lcnr

also rip out the compress universe for inputs, all inputs should now be in the root.

compiler-errors · 2025-06-23T20:43:40Z

@bors2 try @rust-timer queue

rust-bors · 2025-06-23T20:43:44Z

⌛ Trying commit 782f2d1 with merge d69c32b…

To cancel the try build, run the command @bors2 try cancel.

[perf] Canonicalize input ty/ct infer/placeholder in the root universe meow

rust-bors · 2025-06-23T23:14:06Z

☀️ Try build successful (CI)
Build commit: d69c32b (d69c32bb48809cf202e1b423d21ff0f694fc7f9a, parent: 706f244db581212cabf2e619e0113d70999b2bbe)

rust-timer · 2025-06-24T02:19:14Z

Finished benchmarking commit (d69c32b): comparison URL.

Overall result: ✅ improvements - no action needed

Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-1.3%	[-2.4%, -0.3%]	13
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results (primary -1.3%, secondary -1.8%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-1.3%	[-1.3%, -1.3%]	1
Improvements ✅ (secondary)	-1.8%	[-1.8%, -1.8%]	1
All ❌✅ (primary)	-1.3%	[-1.3%, -1.3%]	1

Cycles

Results (secondary -2.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.0%	[-2.7%, -1.7%]	7
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 688.989s -> 688.708s (-0.04%)
Artifact size: 371.96 MiB -> 371.86 MiB (-0.03%)

rustbot · 2025-06-24T03:38:10Z

r? @SparrowLii

rustbot has assigned @SparrowLii.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

compiler-errors · 2025-06-24T03:38:31Z

ty @lcnr for the suggestion, perf looks a bit better now :3

lcnr · 2025-06-24T07:37:19Z

r? lcnr

lcnr · 2025-07-03T13:27:52Z

compiler/rustc_next_trait_solver/src/canonicalizer.rs

+                let var_kinds = self.delegate.cx().mk_canonical_var_kinds(&var_kinds);
+                (ty::UniverseIndex::ROOT, var_kinds)


can you debug assert that this is actually the case :3

r=me after that

compiler-errors · 2025-07-05T18:46:05Z

@bors r=lcnr

bors · 2025-07-05T18:46:07Z

📌 Commit 4185874 has been approved by lcnr

It is now in the queue for this repository.

bors · 2025-07-05T20:34:11Z

⌛ Testing commit 4185874 with merge 5adb489...

bors · 2025-07-05T23:39:27Z

☀️ Test successful - checks-actions
Approved by: lcnr
Pushing 5adb489 to master...

github-actions · 2025-07-05T23:42:03Z

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 175e043 (parent) -> 5adb489 (this PR)

Test differences

Show 3 test diffs

3 doctest diffs were found. These are ignored, as they are noisy.

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 5adb489a8034f7b56b29f3b28af0813c866f679c --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

dist-aarch64-linux: 8011.2s -> 5427.7s (-32.2%)
dist-apple-various: 6485.9s -> 7624.7s (17.6%)
x86_64-rust-for-linux: 2539.3s -> 2822.6s (11.2%)
x86_64-apple-1: 6826.3s -> 6130.4s (-10.2%)
x86_64-gnu-tools: 3277.7s -> 3600.8s (9.9%)
aarch64-gnu: 6227.2s -> 6793.7s (9.1%)
x86_64-gnu-llvm-20-1: 3268.3s -> 3511.5s (7.4%)
i686-gnu-1: 7196.7s -> 7729.1s (7.4%)
aarch64-apple: 3968.9s -> 4255.6s (7.2%)
dist-x86_64-apple: 8207.3s -> 8774.2s (6.9%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

rust-timer · 2025-07-06T01:41:52Z

Finished benchmarking commit (5adb489): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.3%	[0.3%, 0.3%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-1.0%	[-1.8%, -0.3%]	13
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results (primary -5.4%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-5.4%	[-5.4%, -5.4%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-5.4%	[-5.4%, -5.4%]	1

Cycles

Results (secondary -1.7%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-1.7%	[-2.8%, -0.7%]	2
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 459.09s -> 460.95s (0.41%)
Artifact size: 372.18 MiB -> 372.07 MiB (-0.03%)

rustbot added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver) labels Jun 19, 2025

This comment has been minimized.

Sign in to view

rust-bors bot added a commit that referenced this pull request Jun 19, 2025

Auto merge of #142732 - compiler-errors:more-root, r=<try>

46d20f6

[perf] Canonicalize input ty/ct infer/placeholder in the root universe meow

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jun 19, 2025

This comment has been minimized.

Sign in to view

rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jun 20, 2025

lcnr reviewed Jun 23, 2025

View reviewed changes

compiler-errors force-pushed the more-root branch from 334396a to 782f2d1 Compare June 23, 2025 20:43

This comment has been minimized.

Sign in to view

rust-bors bot added a commit that referenced this pull request Jun 23, 2025

Auto merge of #142732 - compiler-errors:more-root, r=<try>

d69c32b

[perf] Canonicalize input ty/ct infer/placeholder in the root universe meow

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jun 23, 2025

This comment has been minimized.

Sign in to view

rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jun 24, 2025

compiler-errors changed the title ~~[perf] Canonicalize input ty/ct infer/placeholder in the root universe~~ Canonicalize input ty/ct infer/placeholder in the root universe Jun 24, 2025

compiler-errors marked this pull request as ready for review June 24, 2025 03:38

rustbot assigned SparrowLii Jun 24, 2025

rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 24, 2025

compiler-errors assigned lcnr and unassigned SparrowLii Jun 24, 2025

lcnr reviewed Jul 3, 2025

View reviewed changes

lcnr added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 3, 2025

Canonicalize input ty/ct infer/placeholder in the root universe

7f5d286

compiler-errors force-pushed the more-root branch from 782f2d1 to d6bd0f4 Compare July 5, 2025 18:39

Don't compress input universes

4185874

compiler-errors force-pushed the more-root branch from d6bd0f4 to 4185874 Compare July 5, 2025 18:43

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 5, 2025

bors added the merged-by-bors This PR was explicitly merged by bors. label Jul 5, 2025

bors merged commit 5adb489 into rust-lang:master Jul 5, 2025
12 checks passed

rustbot added this to the 1.90.0 milestone Jul 5, 2025

		let var_kinds = self.delegate.cx().mk_canonical_var_kinds(&var_kinds);
		(ty::UniverseIndex::ROOT, var_kinds)

Canonicalize input ty/ct infer/placeholder in the root universe #142732

Canonicalize input ty/ct infer/placeholder in the root universe #142732

Conversation

compiler-errors commented Jun 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

compiler-errors commented Jun 19, 2025

Uh oh!

This comment has been minimized.

rust-bors bot commented Jun 19, 2025

Uh oh!

rust-bors bot commented Jun 19, 2025

Uh oh!

This comment has been minimized.

rust-timer commented Jun 20, 2025

Overall result: ✅ improvements - no action needed

Uh oh!

lcnr left a comment

Choose a reason for hiding this comment

Uh oh!

compiler-errors commented Jun 23, 2025

Uh oh!

This comment has been minimized.

rust-bors bot commented Jun 23, 2025

Uh oh!

rust-bors bot commented Jun 23, 2025

Uh oh!

This comment has been minimized.

rust-timer commented Jun 24, 2025

Overall result: ✅ improvements - no action needed

Uh oh!

rustbot commented Jun 24, 2025

Uh oh!

compiler-errors commented Jun 24, 2025

Uh oh!

lcnr commented Jun 24, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

compiler-errors commented Jul 5, 2025

Uh oh!

bors commented Jul 5, 2025

Uh oh!

bors commented Jul 5, 2025

Uh oh!

bors commented Jul 5, 2025

Uh oh!

Uh oh!

github-actions bot commented Jul 5, 2025

Test differences

Job duration changes

Uh oh!

rust-timer commented Jul 6, 2025

Overall result: ✅ improvements - no action needed

Uh oh!

Uh oh!

compiler-errors commented Jun 19, 2025 •

edited

Loading