-
Notifications
You must be signed in to change notification settings - Fork 13.5k
Move all LLVM externs into the rustc_llvm crate #142897
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Some changes occurred in compiler/rustc_codegen_llvm/src/builder/autodiff.rs cc @ZuseZ4 These commits modify the If this was unintentional then you should revert the changes before this PR is merged. Some changes occurred in compiler/rustc_codegen_llvm/src/llvm/enzyme_ffi.rs cc @ZuseZ4 Some changes occurred in coverage instrumentation. cc @Zalathar |
The job Click to see the possible cause of the failure (guessed by this bot)
|
"T-release", | ||
"requires-nightly", | ||
] | ||
exclude_labels = ["P-*", "T-infra", "T-release", "requires-nightly"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please revert all formatting changes?
#17795 expresses a desire to test the LLVM bindings with
ctest
. A pre-requisite for that is to have all the LLVM externs in once place, rather than spread across multiple crates.Actually testing with
ctest
is blocked because the current version ofctest
uses a long out-of-date parser which cannot cope with eg.extern
blocks among other things. However there appears to be active work to build a new version ofctest
(see https://github.com/rust-lang/libc/tree/main/ctest-next)This PR does not intend to change any behaviour, only to move all FFI code into the
rustc_llvm
crate so that it may be tested at some future time.