Skip to content

Fix install-template.sh for Solaris tr #142908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix install-template.sh for Solaris tr #142908

wants to merge 1 commit into from
+4 −4

Conversation

psumbera
Copy link
Contributor

Allow to run install.sh also on Solaris where tr is not GNU tr.

@rustbot
Copy link
Collaborator

rustbot commented Jun 23, 2025

r? @Kobzol

rustbot has assigned @Kobzol.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Jun 23, 2025
jieyouxu
jieyouxu approved these changes Jun 23, 2025
View reviewed changes
Copy link
Member

@jieyouxu jieyouxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I tried this locally just in case, and I believe this is still compatible with GNU tr

$ echo "abc" | tr '[a-z]-' '[A-Z]_'
ABC
$ echo "abc-def" | tr '[a-z]-' '[A-Z]_'
ABC_DEF
$ tr --version
tr (GNU coreutils) 8.32

@Kobzol
Copy link
Contributor

Kobzol commented Jun 23, 2025

r? @jieyouxu

@rustbot
Copy link
Collaborator

rustbot commented Jun 23, 2025

jieyouxu is not on the review rotation at the moment.
They may take a while to respond.

@jieyouxu
Copy link
Member

Oh I thought I wrote r+ but I guess not...
@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jun 23, 2025

📌 Commit c7bfb11 has been approved by jieyouxu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 23, 2025
workingjubilee added a commit to workingjubilee/rustc that referenced this pull request Jun 23, 2025
@workingjubilee
Rollup merge of rust-lang#142908 - psumbera:solaris-tr, r=jieyouxu
64cfd5b 
Fix install-template.sh for Solaris tr

Allow to run install.sh also on Solaris where tr is not GNU tr.
@workingjubilee workingjubilee mentioned this pull request Jun 23, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jieyouxu jieyouxu jieyouxu approved these changes

Assignees

@jieyouxu jieyouxu

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@psumbera @rustbot @Kobzol @jieyouxu @bors