Skip to content

glpk build fix for gcc-15 (remove duplicate bool typedef) #40226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 14, 2025

Conversation

vbraun
Copy link
Member

@vbraun vbraun commented Jun 8, 2025

Fixes build with gcc 15 / Fedora 42

Copy link

github-actions bot commented Jun 8, 2025

Documentation preview for this PR (built with commit 37573a5; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

@dimpase
Copy link
Member

dimpase commented Jun 8, 2025

I'm not sure - it probably won't compile with older gcc, no?

This probably needs a preprocessor check that __STDC_VERSION__ is at least 202311L

@vbraun
Copy link
Member Author

vbraun commented Jun 9, 2025

Good point. Its probably more portable to just #include stdbool.h, will add that.

@vbraun vbraun force-pushed the fix-glpk-for-gcc-15 branch from c5f501c to 37573a5 Compare June 9, 2025 08:54
@vbraun
Copy link
Member Author

vbraun commented Jun 9, 2025

This is now fixed

Copy link
Member

@dimpase dimpase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@vbraun vbraun merged commit be4f8ac into develop Jun 14, 2025
29 of 30 checks passed
@vbraun vbraun deleted the fix-glpk-for-gcc-15 branch June 15, 2025 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants