Skip to content

[windows] make WindowsSDKs configurable through env variables #82188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 27, 2025

Conversation

charles-zablit
Copy link
Contributor

@charles-zablit charles-zablit commented Jun 11, 2025

We are working on setting up a new LLDB bot to test LLDB support for Swift on Windows. This bot will only run the lldb test suite.

This patch adds a new environment variable which allows to specify which Windows SDKs we want to build programatically.

@charles-zablit charles-zablit requested a review from compnerd as a code owner June 11, 2025 17:32
@charles-zablit
Copy link
Contributor Author

@swift-ci please test windows

@charles-zablit charles-zablit force-pushed the charles-zablit/lldb/new-lldb-windows-bot branch from c1d38ec to 9997443 Compare June 11, 2025 17:34
@charles-zablit
Copy link
Contributor Author

@swift-ci please test windows

@charles-zablit
Copy link
Contributor Author

☝️ this is just to test the changes, I will cleanup the changes before it's ready for review.

@charles-zablit
Copy link
Contributor Author

@swift-ci please test windows

@charles-zablit charles-zablit force-pushed the charles-zablit/lldb/new-lldb-windows-bot branch from 0cf5d13 to adba1bf Compare June 13, 2025 17:33
@charles-zablit
Copy link
Contributor Author

@swift-ci please test windows

@charles-zablit charles-zablit force-pushed the charles-zablit/lldb/new-lldb-windows-bot branch from adba1bf to 8000583 Compare June 16, 2025 10:55
@charles-zablit
Copy link
Contributor Author

@swift-ci please test windows

1 similar comment
@charles-zablit
Copy link
Contributor Author

@swift-ci please test windows

@charles-zablit charles-zablit self-assigned this Jun 23, 2025
@charles-zablit charles-zablit force-pushed the charles-zablit/lldb/new-lldb-windows-bot branch from 78664a2 to 21f205d Compare June 25, 2025 11:27
@charles-zablit charles-zablit changed the title [windows][lldb] add an option to run the lldb test suite faster [windows] make WindowsSDKs configurable through env variables Jun 25, 2025
@charles-zablit
Copy link
Contributor Author

@swift-ci please test

@charles-zablit charles-zablit requested a review from compnerd June 25, 2025 11:28
Copy link
Member

@compnerd compnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to verify, we will still build all the SDKs for Swift CI and the nightly releases, but only build x64 for the LLDB tests?

@charles-zablit
Copy link
Contributor Author

Just to verify, we will still build all the SDKs for Swift CI and the nightly releases, but only build x64 for the LLDB tests?

Yes that's the plan.

@charles-zablit charles-zablit force-pushed the charles-zablit/lldb/new-lldb-windows-bot branch from 21f205d to 344d24d Compare June 25, 2025 17:25
@charles-zablit
Copy link
Contributor Author

@swift-ci please test

@charles-zablit
Copy link
Contributor Author

@swift-ci please test macos

@charles-zablit
Copy link
Contributor Author

@swift-ci please test linux

1 similar comment
@charles-zablit
Copy link
Contributor Author

@swift-ci please test linux

@charles-zablit charles-zablit merged commit 9c83ae4 into main Jun 27, 2025
5 checks passed
@charles-zablit charles-zablit deleted the charles-zablit/lldb/new-lldb-windows-bot branch June 27, 2025 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants