[Concurrency] Task.immediate returning Never error must not have throwing op #82372
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…wing operation rdar://153855920
ktoso
commented
Jun 20, 2025
| @@ -46,7 +47,7 @@ extension Task where Failure == ${FAILURE_TYPE} { | |||
| public static func startSynchronously( | |||
| name: String? = nil, | |||
| priority: TaskPriority? = nil, | |||
| @_implicitSelfCapture @_inheritActorContext(always) _ operation: sending @isolated(any) @escaping () async throws -> Success | |||
| @_implicitSelfCapture @_inheritActorContext(always) _ operation: sending @isolated(any) @escaping () async ${THROWS} -> Success | |||
There was a problem hiding this comment.
this method has hardcoded silgen name already
ktoso
commented
Jun 20, 2025
| @@ -79,7 +80,7 @@ extension Task where Failure == ${FAILURE_TYPE} { | |||
| public static func immediate( | |||
| name: String? = nil, | |||
| priority: TaskPriority? = nil, | |||
| @_implicitSelfCapture @_inheritActorContext(always) operation: sending @isolated(any) @escaping () async throws -> Success | |||
| @_implicitSelfCapture @_inheritActorContext(always) operation: sending @isolated(any) @escaping () async ${THROWS} -> Success | |||
ktoso
commented
Jun 20, 2025
| @@ -256,7 +257,7 @@ extension Task where Failure == ${FAILURE_TYPE} { | |||
| @discardableResult | |||
| public static func startOnMainActor( | |||
| priority: TaskPriority? = nil, | |||
| ${OPERATION_PARAM} | |||
| @_inheritActorContext @_implicitSelfCapture _ operation: __owned @Sendable @escaping @MainActor () async ${THROWS} -> Success | |||
There was a problem hiding this comment.
This is the same as OPERATION_PARAM but moved to the THROWS pattern we use elsewhere in this file
|
@swift-ci please smoke test |
jamieQ
reviewed
Jun 20, 2025
xedin
approved these changes
Jun 20, 2025
| @@ -1,5 +1,4 @@ | |||
| // RUN: %target-build-swift -swift-version 6 %s -strict-concurrency=complete -Xfrontend -verify | |||
|
|
|||
| // RUN: %target-swift-frontend -parse-as-library -swift-version 6 -strict-concurrency=complete -emit-sil -verify %s | |||
There was a problem hiding this comment.
Nit: I don't think -strict-concurrency=complete is viable if -swift-version 6 is set.
There was a problem hiding this comment.
true, i'll fix that :)
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ofc when we return an Never error, the operation cannot be throwing, this fixes that.
The API thankfully is AEIC, and the other place has silgenname already so we're safe from ABI trouble here.
rdar://153855920