[6.2][Concurrency] Task.immediate returning Never error must not have thro… #82373
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…wing operation rdar://153855920
|
@swift-ci please test |
|
@swift-ci please test |
|
Small update from review on main |
ktoso
changed the title
|
What the diff actually is in the generated code:
Notice that that's the Never error functions, so they should not be throwing -- which is the fix this patch does. |
DougGregor
approved these changes
Jun 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: The error = Never overload of Task.immediate accidentally had a
throwsoperation function which is incorrect.Scope/Impact: We'd allow throwing in an immediate task where the error would not be captured and could lead to a runtime crash.
Risk: Low, the functions are AEIC and therefore no ABI impact. Existing code which did throw in such code would be incorrect and at risk of crashing.
Testing: Added test for this case
Reviewed by: @xedin
Original PR: #82372
Radar: rdar://153855920