[cmake] [Synchronization] disable autolinking concurrency and older runtimes #82385
Conversation
justice-adams-apple
requested review from
etcwilde,
compnerd and
edymtt
as code owners
|
@swift-ci smoke test |
| @@ -76,6 +76,9 @@ add_compile_options( | |||
| "$<$<COMPILE_LANGUAGE:Swift>:SHELL:-enable-experimental-feature RawLayout>" | |||
| "$<$<COMPILE_LANGUAGE:Swift>:SHELL:-enable-experimental-feature StaticExclusiveOnly>" | |||
| "$<$<COMPILE_LANGUAGE:Swift>:SHELL:-enable-experimental-feature Extern>" | |||
| "$<$<COMPILE_LANGUAGE:Swift>:SHELL:-runtime-compatibility-version none>" | |||
| "$<$<COMPILE_LANGUAGE:Swift>:-disable-autolinking-runtime-compatibility-dynamic-replacements>" | |||
There was a problem hiding this comment.
Why this and the frontend flag? Won't the frontend flag alone be sufficient?
There was a problem hiding this comment.
@compnerd I'm not entirely sure, I mainly just copied what we had previously and also what we have in the swiftCore implementation . Let me review the differences between those flags 👁️
There was a problem hiding this comment.
Looks like these flags are doing the same thing for two different compatibility libraries: swiftCompatibilityDynamicReplacements and swiftCompatibilityConcurrency. And they are both frontend flags.
https://github.com/swiftlang/swift/blob/main/include/swift/Frontend/BackDeploymentLibs.def
There was a problem hiding this comment.
I would suggest to align the way this flags are specified, so they have the same "shape" and it is easier to spot the different ending -- either as a swiftc flag, or as a swift-frontend flag, e.g. focusing on this line
| "$<$<COMPILE_LANGUAGE:Swift>:-disable-autolinking-runtime-compatibility-dynamic-replacements>" | |
| "$<$<COMPILE_LANGUAGE:Swift>:SHELL:-Xfrontend -disable-autolinking-runtime-compatibility-dynamic-replacements>" |
justice-adams-apple
force-pushed
the
jadams/syncronization-disable-concurrency-import
branch
from
5cc2c98 to
d8d2b3f
Compare
|
@swift-ci smoke test |
justice-adams-apple
force-pushed
the
jadams/syncronization-disable-concurrency-import
branch
from
d8d2b3f to
16ffbd3
Compare
|
@swift-ci smoke test |
|
@swift-ci smoke test MacOs |
|
@swift-ci smoke test |
|
@swift-ci smoke test Windows |
justice-adams-apple
deleted the
jadams/syncronization-disable-concurrency-import
branch
…untimes (swiftlang#82385) Disable autolinking concurrency and older runtimes as part of the Synchronization since they aren't needed
Disable autolinking concurrency and older runtimes as part of the Synchronization since they aren't needed