[Concurrency] Rename Dummy(Main|Task)Executor. #82417
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`UnimplementedExecutor` seems like a better name. rdar://153531418
|
@swift-ci Please smoke test |
franklinsch
approved these changes
Jun 23, 2025
We need to update the new runtime build with the filename change also. rdar://153531418
al45tair
requested review from
etcwilde,
compnerd,
edymtt and
justice-adams-apple
as code owners
|
@swift-ci Please smoke test |
compnerd
approved these changes
Jun 23, 2025
|
@swift-ci Please smoke test Windows platform |
|
That was just added now in 6.2? Did those maybe need to be underscored? |
They were in the original custom global executors changeset; I think it makes sense to make the built-in executor implementations have public names, in case you want some unusual combination thereof. (I haven't managed to land an "SPI all the things" changes because doing that doesn't work for protocol changes and the previous "underscore all the things" was rejected as not what was wanted.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UnimplementedExecutorseems like a better name.rdar://153531418