Extend the existing memoization of NSString's Hashable conformance to cover AnyObjects that are actually NSStrings as well #82440
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… cover AnyObjects that are actually NSStrings as well
|
@swift-ci please test |
|
@swift-ci please Apple Silicon benchmark |
|
@swift-ci please benchmark |
Catfish-Man
commented
Jun 24, 2025
|
@swift-ci please test |
|
@swift-ci please benchmark |
tbkka
reviewed
Jun 24, 2025
tbkka
reviewed
Jun 24, 2025
|
@swift-ci please benchmark |
|
@swift-ci please test |
tbkka
approved these changes
Jun 24, 2025
|
I've verified in lldb that we no longer hit |
|
@swift-ci please Apple Silicon benchmark |
|
Turns out we don't have benchmark coverage for AnyHashable! A local test shows ~18.6% overhead from the conformance lookups |
|
Test failure is clang crashing while trying to compile LLVM, looks like |
|
Verified with a release build locally: 4s -> 3s for 10M iterations |
iThinker
approved these changes
Jun 24, 2025
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes rdar://154123172 (Consider memoizing the lookup for NSString's conformance to Hashable)