[6.2][CSSimplify] Narrow down tuple wrapping for pack expansion matching #82471
+23
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follow-up for swiftlang#82326. The optional injection is only viable is the wrapped type is not yet resolved, otherwise it's safe to wrap the optional. (cherry picked from commit 4804f21)
|
@swift-ci please test |
bnbarham
approved these changes
Jun 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #82467
Explanation:
Follow-up for [CSSimplify] VariadicGenerics: Don't attempt to wrap optional into on… #82326.
The optional injection is only viable is the wrapped type is not yet resolved, otherwise it's safe to wrap the optional.
Resolves: rdar://154221449
Main Branch PR: [CSSimplify] Narrow down tuple wrapping for pack expansion matching #82467
Risk: Low. This narrows down the check added by [CSSimplify] VariadicGenerics: Don't attempt to wrap optional into on… #82326 to apply only to situations when optional types are resolved.
Reviewed By: @hamishknight
Testing: Added new test-cases to the test suite.
(cherry picked from commit 4804f21)