Skip to content

Promote feature NonescapableAccessorOnTrivial to be non-experimental #82474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 26, 2025

Conversation

atrick
Copy link
Contributor

@atrick atrick commented Jun 25, 2025

This flag was not experimental for any good reason; it should always be
enabled. The flag only exists so we can introduce a new API:
UnsafeMutablePointer.mutableSpan. Supported compilers cannot handle the new API.

rdar://154247502 (Promote feature NonescapableAccessorOnTrivial to be
non-experimental)

@atrick
Copy link
Contributor Author

atrick commented Jun 25, 2025

@swift-ci test

@atrick atrick requested a review from glessard June 25, 2025 01:37
@atrick
Copy link
Contributor Author

atrick commented Jun 25, 2025

@swift-ci smoke test

@atrick
Copy link
Contributor Author

atrick commented Jun 25, 2025

This makes the build flag unnecessary: #82463

@atrick atrick requested a review from tshortli June 25, 2025 01:41
@atrick
Copy link
Contributor Author

atrick commented Jun 25, 2025

@swift-ci test

This flag was not experimental for any good reason; it should always be
enabled. The flag only exists so we can introduce a new API:
UnsafeMutablePointer.mutableSpan. Supported compilers cannot handle the new API.

rdar://154247502 (Promote feature NonescapableAccessorOnTrivial to be
non-experimental)
@atrick
Copy link
Contributor Author

atrick commented Jun 25, 2025

@swift-ci test

@atrick atrick enabled auto-merge June 25, 2025 02:13
@atrick
Copy link
Contributor Author

atrick commented Jun 25, 2025

@swift-ci smoke test linux

@atrick
Copy link
Contributor Author

atrick commented Jun 25, 2025

Linux PR testing on main has been blocked all day

Miscellaneous_Plugins.aY4PdU/MySourceGenPlugin/Sources/MySourceGenBuildToolLib/library.swift:7: error: undefined reference to '$sSy10FoundationE20replacingOccurrences2of4with7options5rangeSSqd___qd_0_SS0A10EssentialsE14CompareOptionsVSnySS5IndexVGSgtSyRd__SyRd_0_r0_lF'

@atrick
Copy link
Contributor Author

atrick commented Jun 25, 2025

@swift-ci smoke test linux platform

@atrick
Copy link
Contributor Author

atrick commented Jun 25, 2025

@swift-ci smoke test linux

@atrick atrick merged commit 3309f75 into swiftlang:main Jun 26, 2025
4 of 5 checks passed
@atrick atrick deleted the feature-flag branch June 26, 2025 05:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants