Skip to content

[6.2] Promote feature NonescapableAccessorOnTrivial to be non-experimental #82475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 25, 2025

Conversation

atrick
Copy link
Contributor

@atrick atrick commented Jun 25, 2025

This flag was not experimental for any good reason; it should always be
enabled. The flag only exists so we can introduce a new API:
UnsafeMutablePointer.mutableSpan. Supported compilers cannot handle the new API.

rdar://154247502 (Promote feature NonescapableAccessorOnTrivial to be
non-experimental)

(cherry picked from commit 3dc0e62)

--- CCC ---

Explanation: Promote feature NonescapableAccessorOnTrivial to be
non-experimental

Scope: This does not affect existing code. It blocks introduction of new standard library APIs.

Radar/SR Issue: rdar://154247502 (Promote feature
NonescapableAccessorOnTrivial to be non-experimental)

main PR: #82474

Risk: Low. The only change here is that the standard library can now
make use of this pre-existing feature without adding a new build flag.

Testing: Tests already exist for this feature.

Reviewer: Allan Shortlidge

@atrick atrick requested a review from a team as a code owner June 25, 2025 01:36
@atrick atrick added 🍒 release cherry pick Flag: Release branch cherry picks swift 6.2 labels Jun 25, 2025
@atrick atrick requested review from glessard and tbkka June 25, 2025 01:37
@atrick
Copy link
Contributor Author

atrick commented Jun 25, 2025

@swift-ci test

This flag was not experimental for any good reason; it should always be
enabled. The flag only exists so we can introduce a new API:
UnsafeMutablePointer.mutableSpan. Supported compilers cannot handle the new API.

rdar://154247502 (Promote feature NonescapableAccessorOnTrivial to be
non-experimental)

(cherry picked from commit 3dc0e62)
@atrick atrick force-pushed the 62-feature-flag branch from e8d2f9f to 8514a4c Compare June 25, 2025 01:53
@atrick
Copy link
Contributor Author

atrick commented Jun 25, 2025

@swift-ci test

@atrick atrick requested a review from tshortli June 25, 2025 02:13
@atrick atrick enabled auto-merge June 25, 2025 02:14
@atrick
Copy link
Contributor Author

atrick commented Jun 25, 2025

On windows, ninja crashed before the build started

@atrick
Copy link
Contributor Author

atrick commented Jun 25, 2025

@swift-ci test windows

@atrick atrick merged commit 8fcffa8 into swiftlang:release/6.2 Jun 25, 2025
5 checks passed
@atrick atrick deleted the 62-feature-flag branch June 25, 2025 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🍒 release cherry pick Flag: Release branch cherry picks swift 6.2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants