Skip to content

Use SWIFT_COMPILER_VERSION before SWIFT_TOOLCHAIN_VERSION if it exists #82514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Use SWIFT_COMPILER_VERSION before SWIFT_TOOLCHAIN_VERSION if it exists #82514

wants to merge 1 commit into from

Conversation

bnbarham
Copy link
Contributor

We should eventually split these, but for now SWIFT_COMPILER_VERSION matches SWIFT_TOOLCHAIN_VERSION when it's actually set. Just use it in preference to SWIFT_TOOLCHAIN_VERSION.

@bnbarham
Use SWIFT_COMPILER_VERSION before SWIFT_TOOLCHAIN_VERSION if it exists
3a272d0 
We should eventually split these, but for now SWIFT_COMPILER_VERSION
matches SWIFT_TOOLCHAIN_VERSION when it's actually set. Just use it in
preference to SWIFT_TOOLCHAIN_VERSION.
@bnbarham
Copy link
Contributor Author

@swift-ci please test

@bnbarham
Copy link
Contributor Author

@swift-ci please build toolchain

@bnbarham bnbarham mentioned this pull request Jun 26, 2025
Draft
justice-adams-apple
justice-adams-apple approved these changes Jun 26, 2025
View reviewed changes
Copy link
Contributor

@justice-adams-apple justice-adams-apple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but what is the actual difference between these two variables in terms of how they are used? Are they just redundant

@bnbarham
Copy link
Contributor Author

LGTM, but what is the actual difference between these two variables in terms of how they are used? Are they just redundant

SWIFT_COMPILER_VERSION ends up being what serialization uses to base its compatibility checks on, which I want to separate from the tagged version and eg. what's printed in --version/--print-target-info. But now that I just said that, I realized this isn't what I want - SWIFT_COMPILER_VERSION is actually just the version number itself and not the tag :( (consider eg. swift-6.1-RELEASE vs 6.1.0).

@bnbarham bnbarham marked this pull request as draft June 26, 2025 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justice-adams-apple justice-adams-apple justice-adams-apple approved these changes

@etcwilde etcwilde Awaiting requested review from etcwilde etcwilde is a code owner

@shahmishal shahmishal Awaiting requested review from shahmishal shahmishal is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bnbarham @justice-adams-apple