Skip to content

[NFC][RBI]: rename some utility methods & add more RBI logging #82518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[NFC][RBI]: rename some utility methods & add more RBI logging #82518

wants to merge 2 commits into from
+38 −5

Conversation

jamieQ
Copy link
Contributor

@jamieQ jamieQ commented Jun 26, 2025

two changes:

  1. rename the handleSendNeverSentHelper method to handleSentNeverSendableHelper to make more sense and more closely match existing terminology
  2. adds verbose RBI logging for squelched error code paths to help with debugging

@jamieQ
Copy link
Contributor Author

jamieQ commented Jun 26, 2025

@swift-ci please smoke test

@jamieQ jamieQ marked this pull request as ready for review June 26, 2025 02:33
@jamieQ jamieQ requested a review from eeckstein as a code owner June 26, 2025 02:33
@jamieQ
Copy link
Contributor Author

jamieQ commented Jun 26, 2025

@swift-ci Please test Windows platform

@jamieQ
Copy link
Contributor Author

jamieQ commented Jun 26, 2025

@swift-ci Please smoke test macOS platform

@jamieQ
Copy link
Contributor Author

jamieQ commented Jun 26, 2025

cc @gottesmm would appreciate if you could take a look when you have a chance please

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eeckstein eeckstein Awaiting requested review from eeckstein eeckstein is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jamieQ