[CSSimplify] Skip transitive conformance check if argument is CGFloat or Double
#82541
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
There is an implicit conversion between `CGFloat` and `Double` types so if `CGFloat` argument doesn't satisfy the requirement it's possible that the generic parameter it's passed to be inferred as a `Double` from context and the requirement to be satisfied through this implicit conversion. Resolves: rdar://153461854
|
@swift-ci please test |
|
@swift-ci please test macOS platform |
hamishknight
approved these changes
Jun 27, 2025
This is the same problem as `CGFloat` because the conversion is bi-directional.
xedin
changed the title
CGFloatCGFloat or Double
|
@swift-ci please test source compatibility |
|
@swift-ci please test |
|
@swift-ci please test Windows platform |
|
@swift-ci please test macOS platform |
|
@swift-ci please clean test macOS platform |
|
@swift-ci please test macOS platform |
1 similar comment
|
@swift-ci please test macOS platform |
|
@swift-ci please test Windows platform |
|
Debug source compat is failing for an unrelated reason: |
|
@swift-ci please test Windows platform |
|
@swift-ci please test source compatibility debug |
|
@swift-ci please test Windows platform |
|
@swift-ci please test source compatibility debug |
|
This has performance implications even if we reduce it only to CGFloat, I'll fix it in a different way for now. |
xedin
added a commit
to xedin/swift
that referenced
this pull request
Jun 30, 2025
Gracefully handle `LocatableType` types if they show up during serialization. This is a temporary fix until we can remove `TransitivelyConformsTo` constraint from the solver which is the underlying cause of the issue (see swiftlang#82541). Resolves: rdar://153461854
xedin
added a commit
to xedin/swift
that referenced
this pull request
Jul 1, 2025
Gracefully handle `LocatableType` types if they show up during serialization. This is a temporary fix until we can remove `TransitivelyConformsTo` constraint from the solver which is the underlying cause of the issue (see swiftlang#82541). Resolves: rdar://153461854 (cherry picked from commit 907606e)
susmonteiro
pushed a commit
to susmonteiro/swift
that referenced
this pull request
Jul 2, 2025
Gracefully handle `LocatableType` types if they show up during serialization. This is a temporary fix until we can remove `TransitivelyConformsTo` constraint from the solver which is the underlying cause of the issue (see swiftlang#82541). Resolves: rdar://153461854
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is an implicit conversion between
CGFloatandDoubletypesso if
CGFloat/Doubleargument doesn't satisfy the requirement it'spossible that the generic parameter it's passed to be inferred as a the
other type from context and the requirement to be satisfied through this
implicit conversion.
Resolves: rdar://153461854