[6.2] ClosureSpecializer: don't specialize captures of stack-allocated Objective-C blocks #82560
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
tbkka
approved these changes
Jun 27, 2025
…ctive-C blocks Bail if the closure captures an ObjectiveC block which might _not_ be copied onto the heap, i.e optimized by SimplifyCopyBlock. We can't do this because the optimization inserts retains+releases for captured arguments. That's not possible for stack-allocated blocks. Fixes a mis-compile rdar://154241245
eeckstein
force-pushed
the
fix-closure-specializer-6.2
branch
from
56dfd61 to
9952649
Compare
|
@swift-ci test |
|
@swift-ci test macos |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
copy_blocksimplification #81328. The ClosureSpecializer inserted retains+releases for stack-allocated Objective-C blocks. The fix is to bail if the closure captures an ObjectiveC block which might not be copied onto the heap, i.e optimized by SimplifyCopyBlock.