-
Notifications
You must be signed in to change notification settings - Fork 10.5k
Runtimes: adjust the linking to _Concurrency
#82577
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@swift-ci please smoke test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than one test, I don't see where concurrency is used in the String Processing libraries. Can we pass -disable-implicit-import-concurrency
instead and avoid having to link it?
`_Concurrency` is being implicitly imported and then linked into the runtime. Disable the implicit import of the concurrency runtime to allow proper control over the linkage for the library.
@swift-ci please smoke test |
@swift-ci please smoke test macOS platform |
@swift-ci please test windows platform |
@swift-ci please test Windows platform |
@swift-ci please test Windows platform |
_Concurrency
is being implicitly imported and then linked into the runtime (and is required for the asynchronous code). Ensure that we explicitly link against the concurrency runtime to use the correct declarations and ensure that the autolinking works properly for static and dynamic variants of the runtime.