Runtimes: fix a couple of runtime build bugs #82582
Open
+4
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`_Concurrency` is being implicitly imported and then linked into the runtime. Disable the implicit import of the concurrency runtime to allow proper control over the linkage for the library.
When building the standard libraries with the LLVM ADT types, we use the local definition which have been modified to avoid ODR violations. However, due to the intermingling of the compiler and runtime implementations, we cannot isolate the headers properly to ensure that the right definition is used. We need to ensure that we pass along `SWIFT_RUNTIME` when processing headers to avoid references to the unsafe references to the LLVM Support library.
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids the introduction of ODR violations in the Concurrency runtime builds due to missing build flags. It also cleans up the overlinking of
swift_Concurrencyintoswift_StringProcessing.This impacts the builds of
swift_Concurrencyandswift_StringProcessingwhen built with the new build system.Runtimes: adjust the linking to
_Concurrency#82577 Runtimes: avoid ODR violations in _Concurrency #82578These are relatively low risk changes - they only impact how we build the libraries.
Built the runtime libraries on Windows at desk and CI.
@etcwilde