[Concurrency] Fix a crash caused by misuse of isolated modifier
#82593
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bnbarham
reviewed
Jun 28, 2025
Adjust isolation checking to handle misused `isolated` attribute and let attribute checker property diagnose it. Resolves: rdar://148076903 Resolves: swiftlang#80363
|
@swift-ci please test |
|
@swift-ci please test macOS platform |
|
@swift-ci please test Windows platform |
bnbarham
approved these changes
Jun 30, 2025
ktoso
reviewed
Jun 30, 2025
|
|
||
| func testLocal() { | ||
| isolated let c = C() | ||
| // expected-error@-1 {{'isolated' may only be used on 'deinit' declarations}} |
There was a problem hiding this comment.
the error message isn't quite right. it may also be used on parameters today: func p(a: isolated A) where A is an : Actor
There was a problem hiding this comment.
Right, this is just a crash fix, we can adjust the message separately.
ktoso
reviewed
Jun 30, 2025
| class C {} | ||
|
|
||
| func testLocal() { | ||
| isolated let c = C() |
There was a problem hiding this comment.
Note that in the future we'd actually want to support that kinda, in those cases:
func p(pp: isolated P) {
isolated let c = pp // carry "forward" that it was isolated
}
This was referenced Jun 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjust isolation checking to handle misused
isolatedattribute and let attribute checker property diagnose it.Resolves: rdar://148076903
Resolves: #80363