Offer additional note for why method with Self reference cannot be used on any SomeType #82601
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e used on existantials.
Update test cases that emit the could_not_use_member_on_existential error to also check for the associated could_not_use_member_on_existential_note note.
…f-referencing members Emit the `could_not_use_member_on_existential_note` diagnostic when a member reference fails due to constraints involving `Self` or associated types that cannot be resolved on an existential value. This provides more precise guidance by explicitly referencing types like `Self.A` that appear in the member's signature or constraints. The note is emitted after performing member lookup and inspecting viable and unviable candidates for dependent types rooted in `Self`. Improves diagnostics for issue: swiftlang#76320 No functional changes outside of diagnostics.
SwiftyJoeyy
requested review from
AnthonyLatsis,
hborla,
slavapestov and
xedin
as code owners
|
@AnthonyLatsis Just a reminder to take a look at this when you're able to 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #76320