ClangImporter: Generate and call custom availability domain predicates #82940
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nest the `if #available` queries in functions so that it's easier to check the resulting IR unambiguously.
tshortli
requested review from
jckarter,
AnthonyLatsis,
rjmccall,
artemcm,
zoecarver,
egorzhdan,
beccadax,
ian-twilightcoder,
Xazax-hun,
j-hui,
fahadnayyar,
susmonteiro,
hborla,
slavapestov and
xedin
as code owners
|
@swift-ci please smoke test |
When importing custom availability domains with dynamic predicates from Clang modules, synthesize predicate functions for `if #available` queries and call them when generating SIL. Resolves rdar://138441312.
tshortli
force-pushed
the
silgen-custom-availability-domain-query
branch
from
14e1e01 to
3d722e1
Compare
|
@swift-ci please smoke test |
artemcm
approved these changes
Jul 10, 2025
| if (featureInfo.second.Kind != clang::FeatureAvailKind::Dynamic) | ||
| return nullptr; | ||
|
|
||
| if (!featureInfo.second.Call) |
There was a problem hiding this comment.
Can this happen? i.e.
featureInfo.second.Kind == clang::FeatureAvailKind::Dynamic && !featureInfo.second.Call
There was a problem hiding this comment.
Mostly a defensive measure since Clang is responsible for this invariant and I'd like to fail gracefully if it changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When importing custom availability domains with dynamic predicates from Clang modules, synthesize predicate functions for
if #availablequeries and call them when generating SIL.Resolves rdar://138441312.