Skip to content

wasmstdlib.py: respect args.build_runtime_with_host_compiler #82944

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 10, 2025
Merged

wasmstdlib.py: respect args.build_runtime_with_host_compiler #82944

merged 2 commits into from
Jul 10, 2025

Conversation

MaxDesiatov
Copy link
Contributor

@MaxDesiatov MaxDesiatov commented Jul 10, 2025 •
edited
Loading

This allows quickly building Swift stdlib with WASI when --skip-build-llvm --skip-build-swift --build-runtime-with-host-compiler combination of options is passed to build-script.

@MaxDesiatov
wasmstdlib.py: respect args.build_runtime_with_host_compiler
208b236 
This allows quickly building WASI-libc and Swift stdlib with WASI when `--skip-build-llvm --skip-build-swift --build-runtime-with-host-compiler` combination of options is passed to `build-script`.
@MaxDesiatov MaxDesiatov added build-script Area → utils: The build script python Flag: Python source code WebAssembly Platform: WebAssembly WASI WebAssembly System Interface support labels Jul 10, 2025
@MaxDesiatov
Copy link
Contributor Author

@swift-ci smoke test

@MaxDesiatov MaxDesiatov enabled auto-merge (squash) July 10, 2025 11:35
@MaxDesiatov MaxDesiatov added the cross-compilation Area → utils: Cross-compilation of project sources label Jul 10, 2025
kateinoigakukun
kateinoigakukun approved these changes Jul 10, 2025
View reviewed changes
Copy link
Member

@kateinoigakukun kateinoigakukun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm ok with this but doesn't native-{swift,clang,llvm}-tools-path satisfy your needs?

@MaxDesiatov
Copy link
Contributor Author

MaxDesiatov commented Jul 10, 2025 •
edited
Loading

I'm ok with this but doesn't native-{swift,clang,llvm}-tools-path satisfy your needs?

When a nightly development snapshot is installed and is available in PATH it's easier to use that directly when possible and to pass --skip-build-llvm --skip-build-swift --build-runtime-with-host-compiler to build-script to avoid needless toolchain rebuilding. Defaults are not changed, so the purpose is only for local at-desk incremental development.

@MaxDesiatov
Copy link
Contributor Author

@swift-ci smoke test

1 similar comment
@MaxDesiatov
Copy link
Contributor Author

@swift-ci smoke test

@MaxDesiatov
Copy link
Contributor Author

@swift-ci smoke test macos

2 similar comments
@MaxDesiatov
Copy link
Contributor Author

@swift-ci smoke test macos

@MaxDesiatov
Copy link
Contributor Author

@swift-ci smoke test macos

@MaxDesiatov MaxDesiatov merged commit b0f1283 into swiftlang:main Jul 10, 2025
3 checks passed
@MaxDesiatov MaxDesiatov deleted the maxd/wasmstdlib-host-compiler branch July 10, 2025 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kateinoigakukun kateinoigakukun kateinoigakukun approved these changes

@bnbarham bnbarham Awaiting requested review from bnbarham

@etcwilde etcwilde Awaiting requested review from etcwilde etcwilde is a code owner

@justice-adams-apple justice-adams-apple Awaiting requested review from justice-adams-apple justice-adams-apple is a code owner

@shahmishal shahmishal Awaiting requested review from shahmishal shahmishal is a code owner

Assignees
No one assigned
Labels
build-script Area → utils: The build script cross-compilation Area → utils: Cross-compilation of project sources python Flag: Python source code WASI WebAssembly System Interface support WebAssembly Platform: WebAssembly
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MaxDesiatov @kateinoigakukun