Hide files excluded with files.exclude from Project Panel
#1626
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plemarquand
requested review from
adam-fowler,
0xTim and
award999
as code owners
award999
reviewed
Jun 18, 2025
The project panel should respect the `files.exclude` VS Code setting. This setting is combined with the existing `swift.excludePathsFromPackageDependencies`. The tests required an update to `updateSettings`, as the existing global `files.exclude` settings are combined with the ones set in the test. When setting the settings, verify that all expected settings are present before continuing, but don't require the settings object to be an exact match of what we set.
plemarquand
force-pushed
the
hide-excluded-files-project-panel
branch
from
ba46346 to
9a34ec4
Compare
matthewbastien
approved these changes
Jun 18, 2025
rbenegal
approved these changes
Jun 18, 2025
|
@plemarquand can we save owning some of this logic by using |
award999
requested changes
Jun 19, 2025
award999
approved these changes
Jun 19, 2025
plemarquand
force-pushed
the
hide-excluded-files-project-panel
branch
from
ea29558 to
074f676
Compare
This reverts commit 074f676.
|
@award999 |
award999
added
the
needs verification
award999
added a commit
to award999/vscode-swift
that referenced
this pull request
Jun 24, 2025
plemarquand
pushed a commit
that referenced
this pull request
Jun 24, 2025
|
Verified with 7d54def |
award999
removed
the
needs verification
award999
moved this from Needs Verification
to Done
in Swift Extension for Visual Studio Code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The project panel should respect the
files.excludeVS Code setting. This setting is combined with the existingswift.excludePathsFromPackageDependencies.The tests required an update to
updateSettings, as the existing globalfiles.excludesettings are combined with the ones set in the test. When setting the settings, verify that all expected settings are present before continuing, but don't require the settings object to be an exact match of what we set.