Fix diagnostic parsing when spaces in file name #1633
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
award999
force-pushed
the
diagnostics-spaces
branch
2 times, most recently
from
e340ec2 to
29ad071
Compare
rbenegal
approved these changes
Jun 23, 2025
Also found way to parse out *some* of the "swift" diagnostic style notes. With that in mind, don't make "llvm" the default diagnostic style since it causes friction when switching between building on the command line and in vscode. Issue: swiftlang#1350 swiftlang#1630
award999
force-pushed
the
diagnostics-spaces
branch
from
a2407ba to
2e247a1
Compare
plemarquand
approved these changes
Jun 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also found way to parse out some of the "swift" diagnostic style notes. With that in mind, don't make "llvm" the default diagnostic style since it causes friction when switching between building on the command line and in vscode.
Issue: #1350 #1630