Smarter decisions on if user should be prompted for Xcode change #1640
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you use a swiftly path then you are prompted everytime VSCode opens
even if the xcode-select -p is the same. Example settings:
```
"swift.path": "${userHome}/.swiftly/bin",
"swift.swiftEnvironmentVariables": {
"DEVELOPER_DIR": "/Applications/Xcode.app/Contents/Developer"
},
```
So consider the DEVELOPER_DIR as well to know if this changed.
Issue: swiftlang#1472
plemarquand
approved these changes
Jun 23, 2025
rbenegal
reviewed
Jun 23, 2025
| } else if (developerDir() && !matchesDeveloperDir(this.xcodePath)) { | ||
| const selected = await vscode.window.showWarningMessage( | ||
| 'The Swift Extension has detected a change in the selected Xcode which does not match the value of your DEVELOPER_DIR in the "swift.swiftEnvironmentVariables" setting. Would you like to update your configured "swift.swiftEnvironmentVariables" setting?', | ||
| "Remove From Settings", |
There was a problem hiding this comment.
Hmm, thinking a bit more about Remove From Settings and I'm not sure if I could figure out what this actually does if I just saw the pop-up directly. I think this is fine for now, but maybe in the future it could something like Clear swiftEnvironmentVariables settings (or maybe "reset")?
rbenegal
approved these changes
Jun 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you use a swiftly path then you are prompted everytime VSCode opens
even if the xcode-select -p is the same. Example settings:
So consider the DEVELOPER_DIR as well to know if this changed.
Issue: #1472