Fix improper parenting of tests w/ identical names in explorer #1664
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Two tests in swift-testing can share the same identifier, for instance if you have two identically named tests with the same name but that take arguments of different types, i.e: ``` @test(arguments: [1]) func a(_ x: Int) {} @test(arguments: ["a"]) func a(_ x: String) {} ``` In this case sourcekit-lsp provides a disambiguated id with the filename/line number at the end. The code to synthesize parents in the test explorer when provided with test items that had none didn't take in to account this form of disambiguated id, which lead to tests being incorrectly synthesized and parented to the wrong test.
plemarquand
requested review from
adam-fowler,
0xTim and
award999
as code owners
plemarquand
force-pushed
the
file-disambiguated-same-name
branch
from
67816ef to
08dd7d7
Compare
rbenegal
approved these changes
Jun 30, 2025
|
Changelog entry 🙏 |
award999
added
the
needs verification
|
Verified with c3abc77 |
1 similar comment
|
Verified with c3abc77 |
award999
removed
the
needs verification
award999
moved this from Needs Verification
to Done
in Swift Extension for Visual Studio Code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two tests in swift-testing can share the same identifier, for instance if you have two identically named tests with the same name but that take arguments of different types, i.e:
In this case sourcekit-lsp provides a disambiguated id with the filename/line number at the end, i.e.
TestTarget/a:File.swift:2:2.The code to synthesize parents in the test explorer when provided with test items that had none didn't take in to account this form of disambiguated id, which lead to these identically named tests being incorrectly synthesized and parented to the wrong test.