-
Notifications
You must be signed in to change notification settings - Fork 80
Code Lenses for Tests #1698
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Code Lenses for Tests #1698
Conversation
d8ebd63
to
e8fde26
Compare
It's fine with me either way but just asking that are we sure we want the "Run w/ coverage" button? Us having some telemetry about how much users use these buttons would have been nice, but that's a big can of worms ... |
8ce4da7
to
9d399ed
Compare
@MahdiBM I do use the "run with coverage" option sometimes on a single test as I want to make sure my test is exercising what I think it is. Maybe the setting shouldn't be a binary on/off but a tri-state of on/off/specific buttons I want to see |
9d399ed
to
be61e65
Compare
Hmm I think on/off is fine, I dont think having an extra button will be annoying. Though having the ability to choose specific buttons will be an improvement even if little, so that's also fine. |
@MahdiBM After some discussion I've turned these on by default. If you want fine grained control over which lenses appear you can set some permutation of |
When the `swift.showTestCodeLenses` setting is `true`, show code lenses inline in the editor above suites and tests. This setting defaults to `false` and must be enabled first. The three lenses are Run, Debug, and Run w/ Coverage.
38b234b
to
0f87700
Compare
When the
swift.showTestCodeLenses
setting istrue
, show code lenses inline in the editor above suites and tests. This setting defaults tofalse
and must be enabled first.The three lenses are Run, Debug, and Run w/ Coverage.
Issue: #1695