[TOOL-4856] Engine Server wallets table UI adjustment, Fix Vault Portal Link #7419

MananTank · 2025-06-23T21:20:18Z

PR-Codex overview

This PR focuses on enhancing the user interface and experience in the dashboard by updating the Link component and modifying the rendering logic for server wallets in the wallet-table-ui.client.tsx file.

Detailed summary

Updated the href in the Link component from https://portal.thirdweb.com/engine/vault to https://portal.thirdweb.com/vault.
Added the text "Learn more about Vault" below the Link.
Changed the rendering logic for wallets:
- Removed the previous conditional rendering for empty wallets.
- Added a message "No server wallets found" when wallets.length is 0.
- Simplified the mapping of wallets directly without the empty check.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Summary by CodeRabbit

Bug Fixes
- Improved the display of the "No server wallets found" message, which now appears below the wallets table instead of inside it for better clarity.
Style
- Updated the "Learn more about Vault" link to display clear link text and corrected its URL for improved user navigation.

linear · 2025-06-23T21:20:20Z

TOOL-4856 Label is off-center

vercel · 2025-06-23T21:20:21Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
thirdweb-www	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jun 23, 2025 11:23pm

4 Skipped Deployments

Name	Status	Updated (UTC)
docs-v2	⬜️ Skipped (Inspect)	Jun 23, 2025 11:23pm
nebula	⬜️ Skipped (Inspect)	Jun 23, 2025 11:23pm
thirdweb_playground	⬜️ Skipped (Inspect)	Jun 23, 2025 11:23pm
wallet-ui	⬜️ Skipped (Inspect)	Jun 23, 2025 11:23pm

changeset-bot · 2025-06-23T21:20:22Z

⚠️ No Changeset found

Latest commit: 0297411

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

coderabbitai · 2025-06-23T21:20:24Z

Walkthrough

The pull request updates the empty state rendering for the server wallets table by moving the "No server wallets found" message outside the table structure and displaying it in a centered div. Additionally, it updates a link in the Vault FTUX component to use a new URL and adds visible link text.

Changes

File(s)	Change Summary
.../transactions/analytics/ftux.client.tsx	Updated the Vault link URL and added visible link text to the `CreateVaultAccountStep` component.
.../transactions/server-wallets/wallet-table/wallet-table-ui.client.tsx	Refactored empty state rendering: moved "No server wallets found" message outside the table body.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant WalletsTableUI

    User->>WalletsTableUI: Loads wallets table
    alt Wallets array is not empty
        WalletsTableUI->>User: Render wallet rows in table
    else Wallets array is empty
        WalletsTableUI->>User: Render empty table body
        WalletsTableUI->>User: Show "No server wallets found" message below table
    end

Assessment against linked issues

Objective	Addressed	Explanation
Label is off-center (TOOL-4856)	✅

Suggested reviewers

jnsdls

Warning

Review ran into problems

🔥 Problems

Errors were encountered while retrieving linked issues.

Errors (1)

TEAM-0000: Entity not found: Issue - Could not find referenced Issue.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3a5ef31 and 0297411.

📒 Files selected for processing (2)

apps/dashboard/src/app/(app)/team/[team_slug]/[project_slug]/(sidebar)/transactions/analytics/ftux.client.tsx (1 hunks)
apps/dashboard/src/app/(app)/team/[team_slug]/[project_slug]/(sidebar)/transactions/server-wallets/wallet-table/wallet-table-ui.client.tsx (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (2)

apps/dashboard/src/app/(app)/team/[team_slug]/[project_slug]/(sidebar)/transactions/analytics/ftux.client.tsx
apps/dashboard/src/app/(app)/team/[team_slug]/[project_slug]/(sidebar)/transactions/server-wallets/wallet-table/wallet-table-ui.client.tsx

⏰ Context from checks skipped due to timeout of 90000ms (6)

GitHub Check: Size
GitHub Check: E2E Tests (pnpm, vite)
GitHub Check: E2E Tests (pnpm, webpack)
GitHub Check: Unit Tests
GitHub Check: Lint Packages
GitHub Check: Analyze (javascript)

✨ Finishing Touches

📝 Generate Docstrings

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

MananTank · 2025-06-23T21:20:38Z

[TOOL-4856] Engine Server wallets table UI adjustment, Fix Vault Portal Link #7419 👈 (View in Graphite)
main

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

merge-queue - adds this PR to the back of the merge queue
hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

codecov · 2025-06-23T21:22:47Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.08%. Comparing base (b5114df) to head (0297411).
Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #7419   +/-   ##
=======================================
  Coverage   52.08%   52.08%           
=======================================
  Files         947      947           
  Lines       63636    63636           
  Branches     4222     4222           
=======================================
  Hits        33146    33146           
  Misses      30384    30384           
  Partials      106      106

Flag	Coverage Δ
packages	`52.08% <ø> (ø)`

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

github-actions · 2025-06-23T21:25:20Z

size-limit report 📦

Path	Size	Loading time (3g)	Running time (snapdragon)	Total time
thirdweb (esm)	62.56 KB (0%)	1.3 s (0%)	280 ms (+147.32% 🔺)	1.6 s
thirdweb (cjs)	350.74 KB (0%)	7.1 s (0%)	1.1 s (+12.86% 🔺)	8.1 s
thirdweb (minimal + tree-shaking)	5.72 KB (0%)	115 ms (0%)	136 ms (+1653.3% 🔺)	250 ms
thirdweb/chains (tree-shaking)	530 B (0%)	11 ms (0%)	99 ms (+3544.08% 🔺)	109 ms
thirdweb/react (minimal + tree-shaking)	19.61 KB (0%)	393 ms (0%)	138 ms (+787.65% 🔺)	530 ms

graphite-app · 2025-06-23T23:14:19Z

Merge activity

Jun 23, 11:14 PM UTC: MananTank added this pull request to the Graphite merge queue.
Jun 23, 11:23 PM UTC: Merged by the Graphite merge queue.

…al Link (#7419)   --- ## PR-Codex overview This PR primarily focuses on enhancing the user interface in the dashboard by improving the handling of server wallets and updating the link for the Vault. ### Detailed summary - Updated the `href` in the `Link` component to point to `https://portal.thirdweb.com/vault` and added a "Learn more about Vault" text. - Refactored the rendering logic for wallets: - Removed the conditional rendering for "No server wallets found" and replaced it with a new div that displays this message when there are no wallets. - Streamlined the mapping of `wallets` to display each wallet's details within a `TableRow`. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`   ## Summary by CodeRabbit - **Bug Fixes** - Improved the display of the "No server wallets found" message, which now appears below the wallets table instead of inside it for better clarity. - **Style** - Updated the "Learn more about Vault" link to display clear link text and corrected its URL for improved user navigation.

vercel bot temporarily deployed to Preview – docs-v2 June 23, 2025 21:20 Inactive

vercel bot temporarily deployed to Preview – nebula June 23, 2025 21:20 Inactive

vercel bot temporarily deployed to Preview – wallet-ui June 23, 2025 21:20 Inactive

vercel bot temporarily deployed to Preview – thirdweb_playground June 23, 2025 21:20 Inactive

MananTank marked this pull request as ready for review June 23, 2025 21:20

github-actions bot added the Dashboard Involves changes to the Dashboard. label Jun 23, 2025

MananTank requested a review from a team as a code owner June 23, 2025 21:20

github-actions bot assigned MananTank Jun 23, 2025

MananTank requested a review from a team as a code owner June 23, 2025 21:20

MananTank force-pushed the 06-24-_tool-4856_engine_server_wallets_table_ui_adjustment_fix_vault_portal_link branch from 19f08e4 to 3a5ef31 Compare June 23, 2025 21:21

vercel bot temporarily deployed to Preview – thirdweb_playground June 23, 2025 21:21 Inactive

vercel bot temporarily deployed to Preview – nebula June 23, 2025 21:21 Inactive

vercel bot temporarily deployed to Preview – wallet-ui June 23, 2025 21:21 Inactive

vercel bot temporarily deployed to Preview – docs-v2 June 23, 2025 21:21 Inactive

vercel bot deployed to Preview – thirdweb-www June 23, 2025 21:34 View deployment

jnsdls approved these changes Jun 23, 2025

View reviewed changes

graphite-app bot force-pushed the 06-24-_tool-4856_engine_server_wallets_table_ui_adjustment_fix_vault_portal_link branch from 3a5ef31 to 0297411 Compare June 23, 2025 23:14

vercel bot temporarily deployed to Preview – nebula June 23, 2025 23:14 Inactive

vercel bot temporarily deployed to Preview – wallet-ui June 23, 2025 23:14 Inactive

vercel bot temporarily deployed to Preview – docs-v2 June 23, 2025 23:14 Inactive

vercel bot temporarily deployed to Preview – thirdweb_playground June 23, 2025 23:14 Inactive

vercel bot deployed to Preview – thirdweb-www June 23, 2025 23:23 View deployment

graphite-app bot merged commit 0297411 into main Jun 23, 2025
24 checks passed

graphite-app bot deleted the 06-24-_tool-4856_engine_server_wallets_table_ui_adjustment_fix_vault_portal_link branch June 23, 2025 23:23

vercel bot temporarily deployed to Production – docs-v2 June 23, 2025 23:23 Inactive

vercel bot temporarily deployed to Production – nebula June 23, 2025 23:23 Inactive

vercel bot temporarily deployed to Production – wallet-ui June 23, 2025 23:23 Inactive

vercel bot temporarily deployed to Production – thirdweb_playground June 23, 2025 23:23 Inactive

vercel bot deployed to Production – thirdweb-www June 23, 2025 23:31 View deployment

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[TOOL-4856] Engine Server wallets table UI adjustment, Fix Vault Portal Link #7419

[TOOL-4856] Engine Server wallets table UI adjustment, Fix Vault Portal Link #7419

Uh oh!

MananTank commented Jun 23, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

linear bot commented Jun 23, 2025

Uh oh!

vercel bot commented Jun 23, 2025 •

edited

Loading

Uh oh!

changeset-bot bot commented Jun 23, 2025 •

edited

Loading

Uh oh!

coderabbitai bot commented Jun 23, 2025 •

edited

Loading

Review ran into problems

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

MananTank commented Jun 23, 2025 •

edited

Loading

Uh oh!

codecov bot commented Jun 23, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Jun 23, 2025 •

edited

Loading

Uh oh!

graphite-app bot commented Jun 23, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

[TOOL-4856] Engine Server wallets table UI adjustment, Fix Vault Portal Link #7419

[TOOL-4856] Engine Server wallets table UI adjustment, Fix Vault Portal Link #7419

Uh oh!

Conversation

MananTank commented Jun 23, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR-Codex overview

Detailed summary

Summary by CodeRabbit

Uh oh!

linear bot commented Jun 23, 2025

Uh oh!

vercel bot commented Jun 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

changeset-bot bot commented Jun 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

coderabbitai bot commented Jun 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Sequence Diagram(s)

Assessment against linked issues

Suggested reviewers

Review ran into problems

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

MananTank commented Jun 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to use the Graphite Merge Queue

Uh oh!

codecov bot commented Jun 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

github-actions bot commented Jun 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

size-limit report 📦

Uh oh!

graphite-app bot commented Jun 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Uh oh!

MananTank commented Jun 23, 2025 •

edited by coderabbitai bot

Loading

vercel bot commented Jun 23, 2025 •

edited

Loading

changeset-bot bot commented Jun 23, 2025 •

edited

Loading

coderabbitai bot commented Jun 23, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

MananTank commented Jun 23, 2025 •

edited

Loading

codecov bot commented Jun 23, 2025 •

edited

Loading

github-actions bot commented Jun 23, 2025 •

edited

Loading

graphite-app bot commented Jun 23, 2025 •

edited

Loading