Skip to content

[TOOL-4858] Update Team Usage Overview page UI for free plan #7423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

MananTank
Copy link
Member

@MananTank MananTank commented Jun 23, 2025


PR-Codex overview

This PR focuses on enhancing the UpsellWrapper and related components to improve the user experience for teams on a free plan. It introduces new logic to display upsell content based on the team's billing plan and refines the layout of upsell messages.

Detailed summary

  • Updated import paths for getTeamBySlug and UpsellWrapper.
  • Added UpsellContent component for displaying upsell messages.
  • Implemented logic to show upsell content when the team is on a "free" plan.
  • Refined layout and styling of the UpsellWrapper.
  • Enhanced UpsellContent to include benefits and upgrade options.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Summary by CodeRabbit

  • Refactor

    • Extracted upsell card UI into a dedicated component for cleaner and more maintainable code.
    • Updated import paths for improved consistency.
  • Style

    • Enhanced layout and styling of upsell content for better visual alignment.
  • Bug Fixes

    • Simplified error handling on usage page with a consistent message for all errors.
    • Free plan users now see a clear upgrade prompt instead of an error message.

Copy link

vercel bot commented Jun 23, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 23, 2025 11:10pm
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Jun 23, 2025 11:10pm
nebula ⬜️ Skipped (Inspect) Jun 23, 2025 11:10pm
thirdweb_playground ⬜️ Skipped (Inspect) Jun 23, 2025 11:10pm
wallet-ui ⬜️ Skipped (Inspect) Jun 23, 2025 11:10pm

@vercel vercel bot temporarily deployed to Preview – wallet-ui June 23, 2025 22:08 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 June 23, 2025 22:08 Inactive
@vercel vercel bot temporarily deployed to Preview – nebula June 23, 2025 22:08 Inactive
Copy link

linear bot commented Jun 23, 2025

@vercel vercel bot temporarily deployed to Preview – thirdweb_playground June 23, 2025 22:08 Inactive
Copy link

changeset-bot bot commented Jun 23, 2025

⚠️ No Changeset found

Latest commit: b5114df

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

coderabbitai bot commented Jun 23, 2025

"""

Walkthrough

The Upsell UI logic was refactored by extracting its content into a new UpsellContent component. The usage page now uses this component to gate access for free plan users, replacing the previous inline error. Import paths were updated for consistency. No business logic was changed.

Changes

File(s) Change Summary
apps/dashboard/src/@/components/blocks/upsell-wrapper.tsx Refactored: Extracted upsell UI into new UpsellContent component; wrapper now delegates rendering to it.
apps/dashboard/src/app/(app)/team/[team_slug]/(team)/~/audit-log/layout.tsx Updated import paths for getTeamBySlug and UpsellWrapper to use absolute paths.
apps/dashboard/src/app/(app)/team/[team_slug]/(team)/~/usage/page.tsx Now uses UpsellContent to gate usage for free plan users; removed special error handling for free plan status.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant UsagePage
    participant UpsellContent

    User->>UsagePage: Request usage page
    UsagePage->>UsagePage: getValidTeamPlan()
    alt Team is on free plan
        UsagePage->>UpsellContent: Render upsell UI
        UpsellContent-->>User: Display upgrade prompt
    else Team is on paid plan
        UsagePage-->>User: Render usage data
    end
Loading

Assessment against linked issues

Objective Addressed Explanation
Use same component (UpsellContent) for gating usage page to avoid error state (TOOL-4858)

Possibly related PRs

  • thirdweb-dev/js#7300: Introduces the original UpsellWrapper component and audit log features, which are directly refactored and extended in this PR.

Suggested reviewers

  • MananTank
    """

Warning

Review ran into problems

🔥 Problems

Errors were encountered while retrieving linked issues.

Errors (1)
  • TEAM-0000: Entity not found: Issue - Could not find referenced Issue.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b4d1132 and b5114df.

📒 Files selected for processing (3)
  • apps/dashboard/src/@/components/blocks/upsell-wrapper.tsx (2 hunks)
  • apps/dashboard/src/app/(app)/team/[team_slug]/(team)/~/audit-log/layout.tsx (1 hunks)
  • apps/dashboard/src/app/(app)/team/[team_slug]/(team)/~/usage/page.tsx (3 hunks)
🚧 Files skipped from review as they are similar to previous changes (3)
  • apps/dashboard/src/app/(app)/team/[team_slug]/(team)/~/audit-log/layout.tsx
  • apps/dashboard/src/app/(app)/team/[team_slug]/(team)/~/usage/page.tsx
  • apps/dashboard/src/@/components/blocks/upsell-wrapper.tsx
⏰ Context from checks skipped due to timeout of 90000ms (6)
  • GitHub Check: Size
  • GitHub Check: E2E Tests (pnpm, webpack)
  • GitHub Check: E2E Tests (pnpm, vite)
  • GitHub Check: Lint Packages
  • GitHub Check: Build Packages
  • GitHub Check: Analyze (javascript)
✨ Finishing Touches
  • 📝 Generate Docstrings

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Jun 23, 2025
Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@MananTank MananTank marked this pull request as ready for review June 23, 2025 22:09
@MananTank MananTank requested review from a team as code owners June 23, 2025 22:09
Copy link

codecov bot commented Jun 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.08%. Comparing base (66270f7) to head (b5114df).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7423   +/-   ##
=======================================
  Coverage   52.08%   52.08%           
=======================================
  Files         947      947           
  Lines       63636    63636           
  Branches     4222     4222           
=======================================
  Hits        33146    33146           
  Misses      30384    30384           
  Partials      106      106           
Flag Coverage Δ
packages 52.08% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

github-actions bot commented Jun 23, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 62.56 KB (0%) 1.3 s (0%) 260 ms (+135.23% 🔺) 1.6 s
thirdweb (cjs) 350.74 KB (0%) 7.1 s (0%) 1.1 s (+12.51% 🔺) 8.1 s
thirdweb (minimal + tree-shaking) 5.72 KB (0%) 115 ms (0%) 134 ms (+1090.91% 🔺) 248 ms
thirdweb/chains (tree-shaking) 530 B (0%) 11 ms (0%) 70 ms (+1375.11% 🔺) 81 ms
thirdweb/react (minimal + tree-shaking) 19.61 KB (0%) 393 ms (0%) 156 ms (+785.27% 🔺) 548 ms

Copy link
Contributor

graphite-app bot commented Jun 23, 2025

Merge activity

<!--

## title your PR with this format: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes"

If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000):

## Notes for the reviewer

Anything important to call out? Be sure to also clarify these in your comments.

## How to test

Unit tests, playground, etc.

-->

<!-- start pr-codex -->

---

## PR-Codex overview
This PR focuses on improving the handling of team usage and upsell features in the dashboard. It introduces new components and logic to display upsell content based on the team's billing plan.

### Detailed summary
- Updated import paths for `getTeamBySlug` and `UpsellWrapper`.
- Added `UpsellContent` component to display upsell information.
- Implemented logic to show upsell content if the team is on a "free" plan.
- Refactored the `UpsellWrapper` to include `UpsellContent`.
- Enhanced rendering of benefits in `UpsellContent`.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->

<!-- This is an auto-generated comment: release notes by coderabbit.ai -->

## Summary by CodeRabbit

- **Refactor**
  - Improved code structure by extracting upsell card UI into a dedicated component, resulting in cleaner and more maintainable code.
  - Updated import paths for consistency and clarity.

- **Style**
  - Adjusted layout classes for better visual alignment of upsell content.

- **Bug Fixes**
  - Unified error handling for usage page, ensuring a consistent message for all error scenarios. Free plan users now see a clear upgrade prompt.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
@graphite-app graphite-app bot force-pushed the 06-24-_tool-4858_update_team_usage_overview_page_ui_for_free_plan branch from b4d1132 to b5114df Compare June 23, 2025 23:02
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground June 23, 2025 23:02 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 June 23, 2025 23:02 Inactive
@vercel vercel bot temporarily deployed to Preview – nebula June 23, 2025 23:02 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui June 23, 2025 23:02 Inactive
@graphite-app graphite-app bot merged commit b5114df into main Jun 23, 2025
24 checks passed
@graphite-app graphite-app bot deleted the 06-24-_tool-4858_update_team_usage_overview_page_ui_for_free_plan branch June 23, 2025 23:11
@vercel vercel bot temporarily deployed to Production – docs-v2 June 23, 2025 23:11 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb_playground June 23, 2025 23:11 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dashboard Involves changes to the Dashboard.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants