Skip to content

[SDK] Fix: Chain name label #7442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 25, 2025
Merged

[SDK] Fix: Chain name label #7442

merged 2 commits into from
Jun 25, 2025

Conversation

gregfromstl
Copy link
Member

@gregfromstl gregfromstl commented Jun 25, 2025


PR-Codex overview

This PR focuses on improving the handling of transaction delays and enhancing the PaymentDetails component by defining chains based on the origin and destination token chain IDs.

Detailed summary

  • Increased the delay for RPC to catch up from 1 second to 2 seconds in useStepExecutor.ts.
  • Added defineChain imports in PaymentDetails.tsx.
  • Updated the chainsQuery to use defineChain for both origin and destination token chain IDs.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Summary by CodeRabbit

  • Refactor
    • Improved the method for extracting and handling chain IDs in payment details, leading to more accurate chain information display.
  • Chores
    • Increased the post-transaction wait time from 1 to 2 seconds after approval or fee-related actions for smoother processing.

@gregfromstl gregfromstl requested review from a team as code owners June 25, 2025 22:29
Copy link

changeset-bot bot commented Jun 25, 2025

⚠️ No Changeset found

Latest commit: 4fc3f8f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Jun 25, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 25, 2025 10:44pm
nebula ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 25, 2025 10:44pm
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 25, 2025 10:44pm
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 25, 2025 10:44pm
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 25, 2025 10:44pm

Copy link
Contributor

coderabbitai bot commented Jun 25, 2025

Walkthrough

Two main updates were made: In the step execution logic, the post-transaction delay was increased from 1 to 2 seconds. In the payment details UI, the method for determining relevant chain IDs for queries was changed to extract and define chain IDs directly from origin and destination tokens at the step level.

Changes

Files/Groups Change Summary
packages/thirdweb/src/react/core/hooks/useStepExecutor.ts Increased delay after approval/fee transaction receipt from 1s to 2s in executeSingleTx function.
packages/thirdweb/src/react/web/ui/Bridge/payment-details/PaymentDetails.tsx Changed chain ID extraction for useChainsQuery to use origin/destination tokens at the step level.

Suggested labels

packages, SDK

Warning

Review ran into problems

🔥 Problems

Errors were encountered while retrieving linked issues.

Errors (1)
  • TEAM-0000: Entity not found: Issue - Could not find referenced Issue.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6712911 and 4fc3f8f.

📒 Files selected for processing (2)
  • packages/thirdweb/src/react/core/hooks/useStepExecutor.ts (1 hunks)
  • packages/thirdweb/src/react/web/ui/Bridge/payment-details/PaymentDetails.tsx (2 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
`**/*.@(ts|tsx)`: Accept a typed 'props' object and export a named function (e.g...

**/*.@(ts|tsx): Accept a typed 'props' object and export a named function (e.g., export function MyComponent()).
Combine class names via 'cn', expose 'className' prop if useful.
Reuse core UI primitives; avoid re-implementing buttons, cards, modals.
Local state or effects live inside; data fetching happens in hooks.
Merge class names with 'cn' from '@/lib/utils' to keep conditional logic readable.
Stick to design-tokens: background ('bg-card'), borders ('border-border'), muted text ('text-muted-foreground') etc.
Use the 'container' class with a 'max-w-7xl' cap for page width consistency.
Spacing utilities ('px-', 'py-', 'gap-*') are preferred over custom margins.
Responsive helpers follow mobile-first ('max-sm', 'md', 'lg', 'xl').
Never hard-code colors – always go through Tailwind variables.
Tailwind CSS is the styling system – avoid inline styles or CSS modules.
Prefix files with 'import "server-only";' so they never end up in the client bundle (for server-only code).

📄 Source: CodeRabbit Inference Engine (.cursor/rules/dashboard.mdc)

List of files the instruction was applied to:

  • packages/thirdweb/src/react/core/hooks/useStepExecutor.ts
  • packages/thirdweb/src/react/web/ui/Bridge/payment-details/PaymentDetails.tsx
⏰ Context from checks skipped due to timeout of 90000ms (8)
  • GitHub Check: Size
  • GitHub Check: Build Packages
  • GitHub Check: E2E Tests (pnpm, webpack)
  • GitHub Check: E2E Tests (pnpm, vite)
  • GitHub Check: E2E Tests (pnpm, esbuild)
  • GitHub Check: Unit Tests
  • GitHub Check: Lint Packages
  • GitHub Check: Analyze (javascript)
🔇 Additional comments (3)
packages/thirdweb/src/react/core/hooks/useStepExecutor.ts (1)

240-240: Good reliability improvement.

Increasing the delay from 1 to 2 seconds after receipt confirmation is a sensible adjustment to allow RPC nodes time to sync state, especially for approval and fee transactions that may affect subsequent operations.

packages/thirdweb/src/react/web/ui/Bridge/payment-details/PaymentDetails.tsx (2)

5-5: Good addition for chain handling.

Adding the defineChain import supports the improved chain ID extraction logic below.


109-112: Excellent refactoring of chain ID extraction.

The new approach directly extracts chain IDs from step-level origin and destination tokens using defineChain, which is cleaner and more aligned with the step-centric data structure. This change likely addresses the chain name label issue mentioned in the PR title by ensuring proper chain objects are created for the query.

✨ Finishing Touches
  • 📝 Generate Docstrings

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

graphite-app bot commented Jun 25, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

Copy link
Contributor

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 62.75 KB (0%) 1.3 s (0%) 404 ms (+102.34% 🔺) 1.7 s
thirdweb (cjs) 351.77 KB (0%) 7.1 s (0%) 1.6 s (+2.46% 🔺) 8.6 s
thirdweb (minimal + tree-shaking) 5.72 KB (0%) 115 ms (0%) 200 ms (+1838.42% 🔺) 314 ms
thirdweb/chains (tree-shaking) 530 B (0%) 11 ms (0%) 55 ms (+975.33% 🔺) 65 ms
thirdweb/react (minimal + tree-shaking) 19.61 KB (0%) 393 ms (0%) 194 ms (+583.6% 🔺) 586 ms

Copy link

codecov bot commented Jun 25, 2025

Codecov Report

Attention: Patch coverage is 16.66667% with 5 lines in your changes missing coverage. Please review.

Project coverage is 51.92%. Comparing base (6712911) to head (4fc3f8f).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...t/web/ui/Bridge/payment-details/PaymentDetails.tsx 20.00% 4 Missing ⚠️
...s/thirdweb/src/react/core/hooks/useStepExecutor.ts 0.00% 1 Missing ⚠️

❌ Your patch status has failed because the patch coverage (16.66%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7442      +/-   ##
==========================================
- Coverage   51.92%   51.92%   -0.01%     
==========================================
  Files         947      947              
  Lines       63871    63875       +4     
  Branches     4216     4216              
==========================================
+ Hits        33165    33166       +1     
- Misses      30600    30603       +3     
  Partials      106      106              
Flag Coverage Δ
packages 51.92% <16.66%> (-0.01%) ⬇️
Files with missing lines Coverage Δ
...s/thirdweb/src/react/core/hooks/useStepExecutor.ts 1.90% <0.00%> (ø)
...t/web/ui/Bridge/payment-details/PaymentDetails.tsx 4.47% <20.00%> (+0.26%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@gregfromstl gregfromstl merged commit e650434 into main Jun 25, 2025
24 of 25 checks passed
@gregfromstl gregfromstl deleted the greg/fix-chain-name-label branch June 25, 2025 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages SDK Involves changes to the thirdweb SDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant