Skip to content

[TOOL-4867] Dashboard: Fix Coin asset page crash on "unlimited" maxClaimableSupply #7457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

MananTank
Copy link
Member

@MananTank MananTank commented Jun 27, 2025


PR-Codex overview

This PR focuses on updating the handling of totalSupply in the SupplyClaimedProgress component and related files, changing its type to allow for the string "unlimited" instead of just a bigint. This improves the representation of supply status in the application.

Detailed summary

  • Changed totalSupply type in SupplyClaimedProgress from bigint to bigint | "unlimited".
  • Updated condition to check for totalSupply as "unlimited" instead of maxUint256.
  • Modified the story for SupplyClaimedProgress to use "unlimited" instead of maxUint256.
  • Adjusted totalSupply logic in TokenDropClaim to return "unlimited" when maxClaimableSupply equals maxUint256.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Summary by CodeRabbit

  • New Features
    • Updated the supply progress display to clearly indicate when the total supply is unlimited.
  • Refactor
    • Simplified the representation of unlimited supply by using a direct string indicator for improved clarity in the UI.

Copy link

vercel bot commented Jun 27, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 27, 2025 4:29pm
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Jun 27, 2025 4:29pm
nebula ⬜️ Skipped (Inspect) Jun 27, 2025 4:29pm
thirdweb_playground ⬜️ Skipped (Inspect) Jun 27, 2025 4:29pm
wallet-ui ⬜️ Skipped (Inspect) Jun 27, 2025 4:29pm

@vercel vercel bot temporarily deployed to Preview – docs-v2 June 27, 2025 12:48 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui June 27, 2025 12:48 Inactive
Copy link

linear bot commented Jun 27, 2025

@vercel vercel bot temporarily deployed to Preview – nebula June 27, 2025 12:48 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground June 27, 2025 12:48 Inactive
Copy link

changeset-bot bot commented Jun 27, 2025

⚠️ No Changeset found

Latest commit: dbc0316

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

coderabbitai bot commented Jun 27, 2025

"""

Walkthrough

The changes update the handling of unlimited token supply in the dashboard's UI components. Instead of representing unlimited supply as a bigint value (maxUint256), the code now uses the string literal "unlimited". This adjustment modifies type definitions, logic, and prop passing to prevent BigInt conversion errors.

Changes

File(s) Change Summary
.../public-pages/_components/supply-claimed-progress.tsx Changed totalSupply prop type from bigint to bigint | "unlimited"; updated logic to check for "unlimited" instead of maxUint256.
.../public-pages/erc20/_components/claim-tokens/claim-tokens-ui.tsx Updated logic to pass "unlimited" string to SupplyClaimedProgress when maxClaimableSupply equals maxUint256.
.../public-pages/_components/supply-claimed-progress.stories.tsx Updated story to use "unlimited" string for unlimited supply; simplified import for BadgeContainer.

Sequence Diagram(s)

sequenceDiagram
    participant ParentComponent as ClaimTokensUI
    participant SupplyClaimedProgress

    ParentComponent->>SupplyClaimedProgress: Pass totalSupply (bigint or "unlimited")
    SupplyClaimedProgress->>SupplyClaimedProgress: Check if totalSupply === "unlimited"
    SupplyClaimedProgress-->>ParentComponent: Render progress (unlimited or finite)
Loading

Assessment against linked issues

Objective Addressed Explanation
Prevent BigInt conversion error for unlimited supply (TOOL-4867)
Represent unlimited supply as a string instead of maxUint256 (TOOL-4867)

Suggested reviewers

  • jnsdls
  • joaquim-verges

Warning

Review ran into problems

🔥 Problems

Errors were encountered while retrieving linked issues.

Errors (1)
  • TEAM-0000: Entity not found: Issue - Could not find referenced Issue.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 451e663 and dbc0316.

📒 Files selected for processing (3)
  • apps/dashboard/src/app/(app)/(dashboard)/(chain)/[chain_id]/[contractAddress]/public-pages/_components/supply-claimed-progress.stories.tsx (2 hunks)
  • apps/dashboard/src/app/(app)/(dashboard)/(chain)/[chain_id]/[contractAddress]/public-pages/_components/supply-claimed-progress.tsx (1 hunks)
  • apps/dashboard/src/app/(app)/(dashboard)/(chain)/[chain_id]/[contractAddress]/public-pages/erc20/_components/claim-tokens/claim-tokens-ui.tsx (2 hunks)
🚧 Files skipped from review as they are similar to previous changes (3)
  • apps/dashboard/src/app/(app)/(dashboard)/(chain)/[chain_id]/[contractAddress]/public-pages/_components/supply-claimed-progress.stories.tsx
  • apps/dashboard/src/app/(app)/(dashboard)/(chain)/[chain_id]/[contractAddress]/public-pages/erc20/_components/claim-tokens/claim-tokens-ui.tsx
  • apps/dashboard/src/app/(app)/(dashboard)/(chain)/[chain_id]/[contractAddress]/public-pages/_components/supply-claimed-progress.tsx
⏰ Context from checks skipped due to timeout of 90000ms (8)
  • GitHub Check: Build Packages
  • GitHub Check: Unit Tests
  • GitHub Check: E2E Tests (pnpm, webpack)
  • GitHub Check: Size
  • GitHub Check: E2E Tests (pnpm, esbuild)
  • GitHub Check: Lint Packages
  • GitHub Check: E2E Tests (pnpm, vite)
  • GitHub Check: Analyze (javascript)
✨ Finishing Touches
  • 📝 Generate Docstrings

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@MananTank MananTank marked this pull request as ready for review June 27, 2025 12:48
@MananTank MananTank requested review from a team as code owners June 27, 2025 12:48
@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Jun 27, 2025
Copy link
Member Author

MananTank commented Jun 27, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@MananTank MananTank added the hotfix This pull request should be prioritized in the merge queue. label Jun 27, 2025 — with Graphite App
@MananTank MananTank changed the title [TOOL-4867] Fix Coin asset page crashing on maxUint256 as maxClaimableSupply [TOOL-4867] Fix Coin asset page crashing on "unlimited" maxClaimableSupply Jun 27, 2025
Copy link

codecov bot commented Jun 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.92%. Comparing base (5640d48) to head (dbc0316).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7457   +/-   ##
=======================================
  Coverage   51.92%   51.92%           
=======================================
  Files         947      947           
  Lines       63932    63932           
  Branches     4216     4216           
=======================================
  Hits        33194    33194           
  Misses      30632    30632           
  Partials      106      106           
Flag Coverage Δ
packages 51.92% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

github-actions bot commented Jun 27, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 63.11 KB (0%) 1.3 s (0%) 295 ms (+137.52% 🔺) 1.6 s
thirdweb (cjs) 352.61 KB (0%) 7.1 s (0%) 969 ms (+9.82% 🔺) 8.1 s
thirdweb (minimal + tree-shaking) 5.72 KB (0%) 115 ms (0%) 106 ms (+1334.83% 🔺) 221 ms
thirdweb/chains (tree-shaking) 530 B (0%) 11 ms (0%) 63 ms (+2192.31% 🔺) 73 ms
thirdweb/react (minimal + tree-shaking) 19.59 KB (0%) 392 ms (0%) 116 ms (+559.17% 🔺) 507 ms

@MananTank MananTank changed the title [TOOL-4867] Fix Coin asset page crashing on "unlimited" maxClaimableSupply [TOOL-4867] Dashboard: Fix Coin asset page crashing on "unlimited" maxClaimableSupply Jun 27, 2025
@MananTank MananTank changed the title [TOOL-4867] Dashboard: Fix Coin asset page crashing on "unlimited" maxClaimableSupply [TOOL-4867] Dashboard: Fix Coin asset page crash on "unlimited" maxClaimableSupply Jun 27, 2025
Copy link
Contributor

graphite-app bot commented Jun 27, 2025

Merge activity

…aimableSupply (#7457)

<!--

## title your PR with this format: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes"

If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000):

## Notes for the reviewer

Anything important to call out? Be sure to also clarify these in your comments.

## How to test

Unit tests, playground, etc.

-->

<!-- start pr-codex -->

---

## PR-Codex overview
This PR focuses on updating the handling of the `totalSupply` property in the `SupplyClaimedProgress` component and related files to support the string value `"unlimited"` instead of using a constant value from `thirdweb/utils`.

### Detailed summary
- Changed `totalSupply` type from `bigint` to `bigint | "unlimited"` in `SupplyClaimedProgress`.
- Updated the condition to check for `"unlimited"` instead of `maxUint256`.
- Modified the story for `SupplyClaimedProgress` to use `"unlimited"` instead of `maxUint256`.
- Adjusted `totalSupply` handling in `TokenDropClaim` to return `"unlimited"` if `maxClaimableSupply` equals `maxUint256`.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->

<!-- This is an auto-generated comment: release notes by coderabbit.ai -->

## Summary by CodeRabbit

* **New Features**
  * Updated the supply progress display to clearly indicate when the total supply is unlimited.
* **Refactor**
  * Improved internal handling and representation of unlimited supply for better clarity in the UI.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
@graphite-app graphite-app bot force-pushed the 06-27-_tool-4867_fix_coin_asset_page_crashing_on_maxuint256_as_maxclaimablesupply branch from 451e663 to dbc0316 Compare June 27, 2025 16:20
@vercel vercel bot temporarily deployed to Preview – nebula June 27, 2025 16:20 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 June 27, 2025 16:20 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui June 27, 2025 16:20 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground June 27, 2025 16:20 Inactive
@graphite-app graphite-app bot merged commit dbc0316 into main Jun 27, 2025
24 checks passed
@graphite-app graphite-app bot deleted the 06-27-_tool-4867_fix_coin_asset_page_crashing_on_maxuint256_as_maxclaimablesupply branch June 27, 2025 16:30
@graphite-app graphite-app bot removed the hotfix This pull request should be prioritized in the merge queue. label Jun 27, 2025
@vercel vercel bot temporarily deployed to Production – nebula June 27, 2025 16:30 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb_playground June 27, 2025 16:30 Inactive
@vercel vercel bot temporarily deployed to Production – wallet-ui June 27, 2025 16:30 Inactive
@vercel vercel bot temporarily deployed to Production – docs-v2 June 27, 2025 16:30 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dashboard Involves changes to the Dashboard.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants