-
Notifications
You must be signed in to change notification settings - Fork 559
Version Packages #7467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version Packages #7467
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
WalkthroughThis update increments version numbers for the Changes
Sequence Diagram(s)sequenceDiagram
participant Developer
participant BuyWidget/CheckoutWidget/TransactionWidget
participant PaymentOptions
Developer->>BuyWidget/CheckoutWidget/TransactionWidget: Passes paymentMethods prop (["crypto", "card"])
BuyWidget/CheckoutWidget/TransactionWidget->>PaymentOptions: Render only specified payment methods
PaymentOptions-->>Developer: User sees only allowed payment options
Possibly related PRs
Suggested labels
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (7)
💤 Files with no reviewable changes (1)
✅ Files skipped from review due to trivial changes (3)
🚧 Files skipped from review as they are similar to previous changes (3)
⏰ Context from checks skipped due to timeout of 90000ms (8)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
8cee17a
to
fcac508
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (3)
packages/wagmi-adapter/CHANGELOG.md (1)
3-4
: Populate the empty changelog section
An empty heading makes the changelog harder to consume. Add at least a one-liner noting the dependency bump so that downstream consumers can quickly see why this version exists.## 0.2.101 + +### Patch Changes +* Internal release – bumps peer/workspace dependency to **thirdweb @ 5.105.4** in lock-step with related packages.packages/nebula/CHANGELOG.md (1)
3-9
: Optionally enrich the changelog with user-facing context
The entry correctly records the dependency bump, but adding a short note that thethirdweb@5.105.4
update introduces the newpaymentMethods
prop (crypto / card selection) would help downstream consumers understand the practical impact without cross-referencing the other package.Example patch:
## 0.2.4 ### Patch Changes - Updated dependencies [[`bc51255`](https://github.com/thirdweb-dev/js/commit/bc512551ab3a685bdb0ac167105f8aa7385d46d8)]: - thirdweb@5.105.4 + - This thirdweb patch adds a **`paymentMethods`** option to `BuyWidget`, `CheckoutWidget`, and `TransactionWidget`, allowing apps to restrict payment to `"crypto"` and/or `"card"`.
packages/thirdweb/CHANGELOG.md (1)
7-7
: Use back-ticks for identifiers to match existing CHANGELOG styleComponent and prop names are usually wrapped in back-ticks for readability.
Proposed tweak:- Adds paymentMethods prop to BuyWidget, CheckoutWidget, and TransactionWidget to control available payment options. Accepts an array of "crypto" and/or "card" values. + Adds `paymentMethods` prop to `BuyWidget`, `CheckoutWidget`, and `TransactionWidget` to control available payment options. Accepts an array of `"crypto"` and/or `"card"` values.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (7)
.changeset/dull-breads-start.md
(0 hunks)packages/nebula/CHANGELOG.md
(1 hunks)packages/nebula/package.json
(1 hunks)packages/thirdweb/CHANGELOG.md
(1 hunks)packages/thirdweb/package.json
(1 hunks)packages/wagmi-adapter/CHANGELOG.md
(1 hunks)packages/wagmi-adapter/package.json
(1 hunks)
💤 Files with no reviewable changes (1)
- .changeset/dull-breads-start.md
🧰 Additional context used
📓 Path-based instructions (2)
`packages/wagmi-adapter/*`: Wagmi ecosystem integration is located in packages/wagmi-adapter/.
packages/wagmi-adapter/*
: Wagmi ecosystem integration is located in packages/wagmi-adapter/.
📄 Source: CodeRabbit Inference Engine (CLAUDE.md)
List of files the instruction was applied to:
packages/wagmi-adapter/CHANGELOG.md
packages/wagmi-adapter/package.json
`packages/thirdweb/*`: Every public symbol in the SDK must have comprehensive TS...
packages/thirdweb/*
: Every public symbol in the SDK must have comprehensive TSDoc with at least one @example block that compiles and custom annotation tags (@beta, @internal, @experimental).
Export everything via the exports/ directory, grouped by feature.
Place tests alongside code: foo.ts ↔ foo.test.ts.
Use real function invocations with stub data in tests; avoid brittle mocks.
Use Mock Service Worker (MSW) for fetch/HTTP call interception in tests.
Keep tests deterministic and side-effect free.
📄 Source: CodeRabbit Inference Engine (CLAUDE.md)
List of files the instruction was applied to:
packages/thirdweb/package.json
packages/thirdweb/CHANGELOG.md
🧠 Learnings (4)
packages/wagmi-adapter/CHANGELOG.md (1)
Learnt from: CR
PR: thirdweb-dev/js#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-25T02:13:08.257Z
Learning: For multi-platform support, provide platform-specific exports and adapters (e.g., React Native, Node.js, Wagmi, Ethers).
packages/thirdweb/package.json (1)
Learnt from: MananTank
PR: thirdweb-dev/js#7356
File: apps/nebula/src/app/not-found.tsx:1-1
Timestamp: 2025-06-17T18:30:52.976Z
Learning: In the thirdweb/js project, the React namespace is available for type annotations (like React.FC) without needing to explicitly import React. This is project-specific configuration that differs from typical TypeScript/React setups.
packages/wagmi-adapter/package.json (2)
Learnt from: CR
PR: thirdweb-dev/js#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-25T02:13:08.257Z
Learning: For multi-platform support, provide platform-specific exports and adapters (e.g., React Native, Node.js, Wagmi, Ethers).
Learnt from: MananTank
PR: thirdweb-dev/js#7356
File: apps/nebula/src/app/not-found.tsx:1-1
Timestamp: 2025-06-17T18:30:52.976Z
Learning: In the thirdweb/js project, the React namespace is available for type annotations (like React.FC) without needing to explicitly import React. This is project-specific configuration that differs from typical TypeScript/React setups.
packages/thirdweb/CHANGELOG.md (1)
undefined
<retrieved_learning>
Learnt from: MananTank
PR: #7227
File: apps/dashboard/src/app/(app)/(dashboard)/(chain)/[chain_id]/[contractAddress]/modules/components/OpenEditionMetadata.tsx:26-26
Timestamp: 2025-05-30T17:14:25.332Z
Learning: The ModuleCardUIProps interface already includes a client prop of type ThirdwebClient, so when components use Omit<ModuleCardUIProps, "children" | "updateButton">
, they inherit the client prop without needing to add it explicitly.
</retrieved_learning>
⏰ Context from checks skipped due to timeout of 90000ms (8)
- GitHub Check: E2E Tests (pnpm, esbuild)
- GitHub Check: E2E Tests (pnpm, vite)
- GitHub Check: E2E Tests (pnpm, webpack)
- GitHub Check: Size
- GitHub Check: Unit Tests
- GitHub Check: Lint Packages
- GitHub Check: Build Packages
- GitHub Check: Analyze (javascript)
🔇 Additional comments (3)
packages/wagmi-adapter/package.json (1)
58-58
: Version bump is correct and semver-safe
^5.85.0
already ranges up to<6.0.0
, so the newthirdweb@5.105.4
is covered. No other manifest tweaks are required.packages/thirdweb/package.json (1)
407-407
: Package version bump aligns with released changes – LGTM
"version": "5.105.4"
matches the changelog and the published changeset. No further action required.packages/nebula/package.json (1)
3-3
: Version bump looks correct
"version": "0.2.4"
is consistent with the changelog entry.
size-limit report 📦
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7467 +/- ##
=======================================
Coverage 51.91% 51.92%
=======================================
Files 949 949
Lines 64149 64149
Branches 4226 4230 +4
=======================================
+ Hits 33306 33312 +6
+ Misses 30737 30731 -6
Partials 106 106
🚀 New features to boost your workflow:
|
This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.
Releases
@thirdweb-dev/nebula@0.2.4
Patch Changes
bc51255
]:thirdweb@5.105.4
Patch Changes
bc51255
Thanks @gregfromstl! - Adds paymentMethods prop to BuyWidget, CheckoutWidget, and TransactionWidget to control available payment options. Accepts an array of "crypto" and/or "card" values.@thirdweb-dev/wagmi-adapter@0.2.101
PR-Codex overview
This PR focuses on updating version numbers and changelogs for various packages, including
thirdweb
,wagmi-adapter
, andnebula
. It introduces new features and dependency updates.Detailed summary
version
inpackages/thirdweb/package.json
from5.105.3
to5.105.4
.version
inpackages/wagmi-adapter/package.json
from0.2.100
to0.2.101
.version
inpackages/nebula/package.json
from0.2.3
to0.2.4
.0.2.4
inpackages/nebula/CHANGELOG.md
.5.105.4
inpackages/thirdweb/CHANGELOG.md
, detailing newpaymentMethods
prop in widgets.Summary by CodeRabbit
New Features
Chores