-
Notifications
You must be signed in to change notification settings - Fork 720
[css-values-5] Can ident() bypass dashed-ident requirements? #12206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I suppose this issue should be generalized to any custom ident restriction. E.g. |
I don't think it should allow bypassing; we have those restrictions for a reason. And I think enforcing it at parse time, when possible, is still useful. I guess we should just define that |
The reason (ambiguity with keywords) isn't an issue with |
Hm, that is true, Stepping back, tho, your example is already not parseable at parse time due to the use of |
Yeah, that's indeed an issue. We get roughly the same problem with the IACVT approach, since we need to figure out if an
Riiight, so we could, for example, "mock"-evaluate the This works until we spec a regular function that returns a string/ident that can't be known at parse-time: we won't be able to check that |
We already have that - So yeah, we do need to worry about this even ignoring arb-sub functions. |
Some properties require
<dashed-idents>
, for examplescroll-timeline-name
. So e.g.scroll-timeline-name:nondash
would be invalid at parse-time. However, with theident()
function, we'll no longer be able to reject those values parse-time:scroll-timeline-name:ident(var(--maybe-dashes-maybe-not) "mytimeline")
.I guess we have two choices:
ident()
to bypass the dashed requirement, makingscroll-timeline-name:ident(timeline)
actually a define a timeline namedtimeline
. (In order for the timeline to be reachable, the name would have to be "escaped" withident()
on theanimation-timeline
side as well).The text was updated successfully, but these errors were encountered: