Bug fix: don't include gvar in all table keyed patches. #109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The check to detect when we transitioned between different design space configurations was incorrect which resulted in all table keyed patches in a font with design space extension including a patch against gvar. This fixes the check and adds a unit test which catches the issue.
garretrieger
force-pushed
the
gvar_handling_fix
branch
from
63686de to
f2ee6d7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The check to detect when we transitioned between different design space configurations was incorrect which resulted in all table keyed patches in a font with design space extension including a patch against gvar. This fixes the check and adds a unit test which catches the issue.