Skip to content

Adding publisher #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

Conversation

aarongustafson
Copy link
Collaborator

Super-early thinking here. Feedback very welcome.

Copy link
Contributor

@tomayac tomayac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the general direction, but may I suggest you build upon the web-app-origin-association file that was introduced in the context of URL handling. Here's the explainer deep link.

@aarongustafson
Copy link
Collaborator Author

@tomayac I had thought about that, but wasn’t sure if it might lead to confusion if the file exists within the individual PWAs and then again (to an extent) on the publisher’s site. I think the URL handling aspect is pretty complex in and of itself and I didn’t want to overload it.

I also wasn’t sure if it would cause a problem if we dropped details in that context. Totally open to your thoughts here.

@tomayac
Copy link
Contributor

tomayac commented Oct 27, 2021

The web-app-origin-association file format already contains a "manifest" field, so I think this could easily work. Something to consider might be to factor in the new unique ID into the verification algorithm.

{
  "web_apps": [
    {
      "manifest": "https://music.example.com/manifest.json",
      "details": {
        "paths": ["/*"],
        "exclude_paths": ["/internal/*"]
      }
    }
  ]
}

@aarongustafson
Copy link
Collaborator Author

@diekus @marcoscaceres Thoughts on this proposal?

@aarongustafson aarongustafson added the enhancement New feature or request label Aug 17, 2023
@tomayac
Copy link
Contributor

tomayac commented Aug 17, 2023

Still thinking about the verification aspect. The web-app-origin-association file is similar to Apple's associated domain file, Android's assetlinks.json file, and Windows' windows-app-web-link file. What differs is that the web-app-origin-association file does not reference PWAs using a platform-specific app

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants