browsersettting: fallback to localStorage/uiDefault for undefined setting #11382
+5
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
codewithvk
force-pushed
the
private/codewithvk/allow_ui_default_settings
branch
2 times, most recently
from
7d9a71e to
c501a6c
Compare
codewithvk
changed the title
codewithvk
force-pushed
the
private/codewithvk/allow_ui_default_settings
branch
from
c501a6c to
f8e5637
Compare
Rash419
requested changes
Mar 20, 2025
codewithvk
force-pushed
the
private/codewithvk/allow_ui_default_settings
branch
from
7b02459 to
2025d7c
Compare
codewithvk
force-pushed
the
private/codewithvk/allow_ui_default_settings
branch
from
2025d7c to
e3a6cf2
Compare
…ting Signed-off-by: codewithvk <vivek.javiya@collabora.com> Change-Id: Ic035f3a5af95f903aff4934e998dd0a38675ccdc
codewithvk
force-pushed
the
private/codewithvk/allow_ui_default_settings
branch
from
e3a6cf2 to
2e5e2c3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
browsersettting: fallback to localStorage/uiDefault for undefined setting
When a browser setting is not defined, use localStorage/uiDefault as a fallback. This fixes the regression related to the saveAsMode issue. bug: #11297
Change-Id: Ic035f3a5af95f903aff4934e998dd0a38675ccdc