Supresses the IO Exception of convert-source-map #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JamesMessinger
requested changes
Apr 6, 2020
There was a problem hiding this comment.
Thanks for the PR, @Pouja! It looks good, but there's one change I'd like you to make to narrow the scope
src/index.ts
Outdated
| } | ||
| } catch (e) { | ||
| // Exception is thrown by fromMapFileSource when there is no source map file | ||
| if (typeof e === "string" || e instanceof Error) { |
There was a problem hiding this comment.
This will suppress all errors, not just the ones related to a missing source map. Please check specifically for the missing-sourcemap error, and only suppress that one. Any other error should be re-thrown.
There was a problem hiding this comment.
Solved it with e.message.includes("An error occurred while trying to read the map file at")
There was a problem hiding this comment.
@JamesMessinger Can you take a look at this?
The IO Exception occurs when in the webpack pipeline some files have the .map counterpart but some dont. If the user enables the stats of webpack, he/she would still see the warnings.
Pouja
force-pushed
the
bugfix/io-exception
branch
from
75a4f9c to
3ccab96
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The IO Exception occurs when in the webpack pipeline some files have the .map counterpart but some don't. In our case it happens when some of the files have
.jsextension where others have.tsIf the user enables the stats of webpack, he/she would still see the warnings.
Closes #5